-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55089/
-----------------------------------------------------------
(Updated Jan. 28, 2017, 1:11 p.m.)
Review request for Aurora, David McLaughlin and Stephan Erb.
Bugs: AURORA-1826
https://issues.apache.org/jira/browse/AURORA-1826
Repository: aurora
Description (updated)
-------
This patch introduces a number of stats that measure the workload generated by
Thrift server requests.
Current Thrift server stats expose the number and timing of requests received
by the server. However, they fail to reflect the size of the requests. This is
limiting us in having an accurate view of the workload handled by the
scheduler. For example, every call to `restartShards()` is recorded as one
event despite the fact that a request might only restart one shard while
another request might seek to restart 1K shards.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0
src/main/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor.java
d57f910d8f9bbe5c24aec960e88d03702bc353da
src/main/java/org/apache/aurora/scheduler/thrift/aop/ThriftWorkload.java
PRE-CREATION
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
b28cd2489a52041a8e7e53f298fad8d8cd29406f
src/test/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptorTest.java
9c40ec51c28c8c57365dc21c3cd7391a3894784c
Diff: https://reviews.apache.org/r/55089/diff/
Testing
-------
```
curl 192.168.33.7:8081/vars | grep thrift_workload
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 41334 0 41334 0 0 3695k 0 --:--:-- --:--:-- --:--:-- 4036k
thrift_workload_addInstances 0
thrift_workload_createJob 0
thrift_workload_createOrUpdateCronTemplate 0
thrift_workload_drainHosts 0
thrift_workload_endMaintenance 0
thrift_workload_getConfigSummary 0
thrift_workload_getJobSummary 0
thrift_workload_getJobUpdateDetails 0
thrift_workload_getJobUpdateSummaries 0
thrift_workload_getJobs 0
thrift_workload_getPendingReason 0
thrift_workload_getRoleSummary 0
thrift_workload_getTaskStatus 0
thrift_workload_getTasksWithoutConfigs 0
thrift_workload_killTasks 0
thrift_workload_maintenanceStatus 0
thrift_workload_restartShards 0
thrift_workload_rewriteConfigs 0
thrift_workload_startJobUpdate 0
thrift_workload_startMaintenance 0
```
```
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
mesos-master start/running, process 2359
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real 28m58.389s
user 0m1.508s
sys 0m0.820s
```
Thanks,
Mehrdad Nurolahzade
