-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/
-----------------------------------------------------------
(Updated Feb. 6, 2017, 6:40 p.m.)
Review request for Aurora, Joshua Cohen and Zameer Manji.
Changes
-------
Update release notes
Bugs: AURORA-1846
https://issues.apache.org/jira/browse/AURORA-1846
Repository: aurora
Description
-------
RPC's such as pauseJobUpdate include a parameter for "a user-specified message
to include with the induced job update state change." This diff provides a
similar optional parameter for the killTasks RPC, which allows users to
indicate the reason why a task was killed, and later inspect that reason when
consuming task events.
Example usage from Aurora CLI: `$ aurora job killall
devcluster/www-data/prod/hello --message "Some message"`
In the task event, the supplied message (if provided) is appended to the
existing template "Killed by <user>", separated by a newline. For the above
example, this looks like: "Killed by aurora\nSome message".
Diffs (updated)
-----
RELEASE-NOTES.md 05fdfb6f7ec5b19986afbc89de33f2773d62b363
api/src/main/thrift/org/apache/aurora/gen/api.thrift
c3ec96584d7acdc50c80fc629f8cff61f2d206d7
src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java
a7aecedcab7a5ae116b0536fe7831689e065ea80
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
a40114d6c49b3892f21aedddcdd3a414675e39f3
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java
bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1
src/main/python/apache/aurora/client/api/__init__.py
e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
src/main/python/apache/aurora/client/cli/jobs.py
8ba41aa914f7ddd301891f67dd763ba50a977a9d
src/main/python/apache/aurora/client/hooks/hooked_api.py
86c3a09481d0504690439b608c269285b9cc2a38
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java
b20900da82915f429c35a68775b2106fb15394ff
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java
05f4a18938be8075e487478cab06ff51874e08a7
src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java
9c8460ce206eb13b4b9910d76d6fcade439c9c61
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
b7574e45368b877807b6b0b391e0ae4a1610b780
src/test/python/apache/aurora/api_util.py
983cde48a48bc2388e8535c3d17b867373c8dcaa
src/test/python/apache/aurora/client/api/test_scheduler_client.py
f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
src/test/python/apache/aurora/client/cli/test_kill.py
564ea440983359ae3c382c58aa249965752fedbc
src/test/python/apache/aurora/client/hooks/test_hooked_api.py
eb97c611d7e17668a3e646722684a847fc491d1a
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py
04b2257cb7e4e78ab90564ab27b160de2b1c8912
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
736d1fcf1d99226efd252336f1630e1f033073ca
Diff: https://reviews.apache.org/r/54459/diff/
Testing
-------
Added a unit test in the scheduler, and a test in the client.
Also manually tested using the Vagrant environment.
File Attachments
----------------
"Some message" shown in UI
https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
Thanks,
Cody Gibb
