Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

[Aurora ReviewBot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56629/#review165428
-----------------------------------------------------------



Master (40d91fe) is red with this patch.
  ./build-support/jenkins/build.sh

                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_process_cannot_depend_upon_daemon
 PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_non_ephemeral_process_cannot_depend_on_ephemeral_process
 PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_failed_predecessor_does_not_make_process_runnable
 PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_daemon_duration
 PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_waits 
PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_fails 
PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_lost 
PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_filters 
PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_max_runs 
PASSED
                     
src/test/python/apache/thermos/common/test_pathspec.py::test_legacy_task_roots 
PASSED
                     
src/test/python/apache/thermos/common/test_pathspec.py::test_legacy_log_dirs 
PASSED
                     
src/test/python/apache/thermos/common/test_pathspec.py::test_exception_on_none_keys
 PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_empty 
PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_unordered 
PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_ordered 
PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_mixed 
PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_unsatisfiables
 PASSED
                     
                     ==================== FAILURES ====================
                     _________________ test_coverage __________________
                     
                         def test_coverage():
                           """Make sure a new thrift RPC doesn't get added 
without minimal test coverage."""
                           for name, klass in 
inspect.getmembers(AuroraAdmin) + 
inspect.getmembers(AuroraSchedulerManager):
                             if name.endswith('_args'):
                               rpc_name = name[:-len('_args')]
                     >         assert 
hasattr(TestSchedulerProxyAdminInjection, 'test_%s' % rpc_name), (
                                   'No test defined for RPC %s' % 
rpc_name)
                     E         AssertionError: No test defined for RPC 
pruneTasks
                     E         assert 
hasattr(TestSchedulerProxyAdminInjection, ('test_%s' % 'pruneTasks'))
                     
                     
src/test/python/apache/aurora/client/api/test_scheduler_client.py:65: 
AssertionError
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/aaf4d108c31293299a0839bdc404a91802f80937.xml
 
                      1 failed, 777 passed, 6 skipped, 1 warnings in 
326.98 seconds 
                     
FAILURE


02:23:08 06:04   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 14, 2017, 2:01 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56629/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2017, 2:01 a.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Zameer 
> Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Expose task pruning endpoint in aurora_admin. Useful for scale testing in 
> order to 'clean up' after a test run, but also useful in production if you 
> have a bad actor inflating the size of your task index.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 6205c2ed1e2d5898a322de5bc2bcba6b2c0cd4b1 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  a211483caf59755b1f9b286b58f183e00db6eee6 
>   src/main/python/apache/aurora/admin/admin.py 
> 070c348d2ca5db1edecf832efd9aa5481bddaa4b 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1250ccd16f906eec08c159df3300d1b94b306d8e 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  0cdd9829417bb3ef0215278a9458a3dd78a49a20 
>   src/test/python/apache/aurora/admin/test_admin.py 
> 66abade378d3974dbf031a7bbed9cd6fc4f22d5f 
> 
> Diff: https://reviews.apache.org/r/56629/diff/
> 
> 
> Testing
> -------
> 
> Ran various combinations of task pruning via aurora_admin in Vagrant. Works 
> as expected. 
> 
> Also:
> 
> ./pants test src/test/python/apache/aurora/admin::
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>