> On Oct. 31, 2016, 8:14 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/config/schema/base.py, lines 137-138 > > <https://reviews.apache.org/r/53333/diff/3/?file=1550506#file1550506line137> > > > > I'd say we should mirror the names from mesos.proto here? > > `container_path` and `host_path`. Right now it's unclear what `container` > > and `host` are exactly. What do you think?
Done. > On Oct. 31, 2016, 8:14 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/config/thrift.py, lines 180-186 > > <https://reviews.apache.org/r/53333/diff/3/?file=1550507#file1550507line180> > > > > I think indentation is off here (should be 4 spaces for continuation?) Done. > On Oct. 31, 2016, 8:14 p.m., Joshua Cohen wrote: > > src/test/sh/org/apache/aurora/e2e/run-server.sh, lines 2-6 > > <https://reviews.apache.org/r/53333/diff/3/?file=1550510#file1550510line2> > > > > This should be a separate process in the e2e test job, rather than > > embedding it in `run-server`? That way it's clear that this check is being > > performed. Done. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53333/#review154365 ----------------------------------------------------------- On Oct. 31, 2016, 6:48 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53333/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 6:48 p.m.) > > > Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and > Stephan Erb. > > > Bugs: AURORA-1107 > https://issues.apache.org/jira/browse/AURORA-1107 > > > Repository: aurora > > > Description > ------- > > Enables the client DSL to set per task volume mounts. This also adds a E2E > test that tests per task volume mounting. > > > Diffs > ----- > > examples/vagrant/upstart/aurora-scheduler.conf > e68a801017ae02e0ed581129e12a645ccc1e35d4 > src/main/python/apache/aurora/config/schema/base.py > 845163043b0b7b2f9e7aca14677ca9f094658551 > src/main/python/apache/aurora/config/thrift.py > 3539469d243638c0acd08bf0859d0ce858d8977c > src/test/python/apache/aurora/config/test_thrift.py > e213184739167e01f3614c20a809af39b3a6b3d6 > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora > c71fb81490863b44827bf090f6e5a6b28da94b93 > src/test/sh/org/apache/aurora/e2e/run-server.sh > 1fe09090bfa3eeb0f6897e8c895782fb1ff949a1 > > Diff: https://reviews.apache.org/r/53333/diff/ > > > Testing > ------- > > sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Zameer Manji > >
