----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/#review168724 -----------------------------------------------------------
Ship it! LGTM. Before shipping, please make sure you fix the failing test (should be trivial) and add a sentance to the release notes that one needs to upgrade to Aurora 0.18 before Mesos can be udpated to 1.2. - Stephan Erb On Feb. 15, 2017, 6:40 a.m., Santhosh Kumar Shanmugham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55951/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2017, 6:40 a.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Karthik Anantha > Padmanabhan. > > > Bugs: AURORA-1882 > https://issues.apache.org/jira/browse/AURORA-1882 > > > Repository: aurora > > > Description > ------- > > MesosContainerizer has updated the command line parameters in 1.2.0 and > consolidated the individual arguments into a single ContainerLaunchInfo > proto buf message. Update ThermosExecutor to use the new `--launch_info` > parameter to be compatible with MesosContainerizer also check the > containerizer binary interface to determine to be backward-compatible. > > > Diffs > ----- > > src/main/python/apache/thermos/common/process_util.py > 54e716b726fc02f3901f1b9143d3fa253511e29b > src/test/python/apache/aurora/executor/common/test_health_checker.py > a3b5a22a805753d42e97f8f1e4e3dab7d3c9c507 > src/test/python/apache/thermos/core/test_process.py > 520390217f691b9136cb4d36262be3d372a16509 > > > Diff: https://reviews.apache.org/r/55951/diff/2/ > > > Testing > ------- > > build-support/jenkins/build.sh > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Santhosh Kumar Shanmugham > >
