-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57487/#review169828
-----------------------------------------------------------
Master (33acb89) is red with this patch.
./build-support/jenkins/build.sh
.setPrincipal(driverSettings.getFrameworkInfo().getPrincipal())
^
symbol: method getFrameworkInfo()
location: variable driverSettings of type DriverSettings
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:386:
error: cannot find symbol
builder.setPrincipal(driverSettings.getFrameworkInfo().getPrincipal());
^
symbol: method getFrameworkInfo()
location: variable driverSettings of type DriverSettings
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:399:
error: cannot find symbol
buildReservation(instanceKey,
driverSettings.getFrameworkInfo().hasPrincipal()))
^
symbol: method getFrameworkInfo()
location: variable driverSettings of type DriverSettings
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:397:
error: cannot find symbol
.setRole(driverSettings.getFrameworkInfo().getRole())
^
symbol: method getFrameworkInfo()
location: variable driverSettings of type DriverSettings
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java:106:
error: constructor DriverSettings in class DriverSettings cannot be applied to
given types;
public static final DriverSettings DRIVER_SETTINGS = new DriverSettings(
^
required: String,Optional<Credential>
found: String,Optional<Object>,FrameworkInfo
reason: actual and formal argument lists differ in length
7 errors
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 1 mins 6.762 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On March 23, 2017, 1:48 a.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57487/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 1:48 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Esteemed reviewers, here is the latest iteration on the implementation of
> dynamic reservations. Some changes are merging of the patches into a single
> one, updated design document with a more high level overview and user stories
> told from an operator’s point of view. Unit TESTS are going to be done as
> soon as we agree on the approach, as I have tested this patch on local
> vagrant and a multi-node dev cluster. Jenkins build is expected to fail as
> tested are incomplete.
>
> For reference, here are previous two patches which feedback I addressed in
> this new single patch.
> Previous 2 patches:
> https://reviews.apache.org/r/56690/
> https://reviews.apache.org/r/56691/
>
> RFC document:
> https://docs.google.com/document/d/15n29HSQPXuFrnxZAgfVINTRP1Iv47_jfcstJNuMwr5A
> Design Doc [UPDATED]:
> https://docs.google.com/document/d/1L2EKEcKKBPmuxRviSUebyuqiNwaO-2hsITBjt3SgWvE
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java
> f2296a9d7a88be7e43124370edecfe64415df00f
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java
> 6f2ca35c5d83dde29c24865b4826d4932e96da80
> src/main/java/org/apache/aurora/scheduler/HostOffer.java
> 23f0600d64e1e15f4856f397e839e3d1c87f3b96
> src/main/java/org/apache/aurora/scheduler/TaskVars.java
> 676dfd9f9d7ee0633c05424f788fd0ab116976bb
> src/main/java/org/apache/aurora/scheduler/TierInfo.java
> c45b949ae7946fc92d7e62f94696ddc4f0790cfa
> src/main/java/org/apache/aurora/scheduler/TierManager.java
> c6ad2b1c48673ca2c14ddd308684d81ce536beca
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java
> b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java
> f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
> 80f0aebd6de0c2d7c30a58ec09702d1c6d519787
>
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
> f6c759f03c4152ae93317692fc9db202fe251122
> src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java
> 0637eb7f85125cf70b588d56fa7dc88130947837
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java
> bb1a960a4c77f48b0ceaa213bd27546551f384f9
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java
> 60097d91d836e2686d6e90571f13a2fbfd88ae14
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
> 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java
> 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java
> e16e36ed360ef9ca371df9084365ea88cfb6e7ce
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java
> 202cae96ffc5b49e638b973a273f7983137b5baf
>
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java
> ba49e7a4ccfaddbd85218018b0bbad5efab41d99
> src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java
> 291d5c95916915afc48a7143759e523fccd52feb
>
> src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java
> 7040004ae48d3a9d0985cb9b231f914ebf6ff5a4
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java
> 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c
>
> src/main/java/org/apache/aurora/scheduler/scheduling/ReservationTimeoutCalculator.java
> PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java
> 03a0e8485d1a392f107fda5b4af05b7f8f6067c6
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java
> 203f62bacc47470545d095e4d25f7e0f25990ed9
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java
> da378e84ee65a658ff2382489d3ab6d5f6451b5f
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java
> 40451e91aed45866c2030d901160cc4e084834df
> src/main/resources/org/apache/aurora/scheduler/tiers.json
> 34ddb1dc769a73115c209c9b2ee158cd364392d8
> src/test/java/org/apache/aurora/scheduler/TierManagerTest.java
> 82e40d509d84c37a19b6a9ef942283d908833840
>
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
> 5419d7edd83c14f155b105b87c5521d7a938e248
> src/test/java/org/apache/aurora/scheduler/http/OffersTest.java
> 30699596a1c95199df7504f62c5c18cab1be1c6c
>
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java
> 93cc34cf8393f969087cd0fd6f577228c00170e9
> src/test/java/org/apache/aurora/scheduler/offers/HostOffers.java
> PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java
> 49d4e82cc03144b80292fe43066a6cc4d7aed88f
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java
> dded9c34749cf599d197ed312ffb6bf63b6033f1
>
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java
> b8b8edb1a21ba89b8b60f8f8451c8c776fc23ae8
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java
> e04f6113c43eca4555ee0719f8208d7c4ebb8d61
>
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java
> fa1a81785802b82542030e1aae786fe9570d9827
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
> cf2d25ec2e407df7159e0021ddb44adf937e1777
>
>
> Diff: https://reviews.apache.org/r/57487/diff/2/
>
>
> Testing
> -------
>
> Tested on local vagrant for following scenarios:
> Reserving a task
> Making sure returned offer comes back
> Making sure offer is unreserved
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
