-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58017/
-----------------------------------------------------------
(Updated March 29, 2017, 1:33 p.m.)
Review request for Aurora and Santhosh Kumar Shanmugham.
Bugs: AURORA-1910
https://issues.apache.org/jira/browse/AURORA-1910
Repository: aurora
Description (updated)
-------
Previously the `framework_registered` metric only transitioned from 0 to 1 on
the first registration. On disconnection and registration loss, the metric was
not updated to reflect the loss of registration.
To make this metric more useful, I have moved this metric from the
`SchedulerLifecycle`, where it was tied to the boolean controlling the
LEADER_AWAITING_REGISTRATION -> ACTIVE transtion, to `MesosCallbackHandler`. In
`MesosCallbackHandler` it can easily be updated to reflect the current state
of registration.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
4e354b6219726c1fdf0b84c4049ce04eda1263ff
src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java
800edfa94d7b77856c00ed6ad6f8b0a641d3530a
src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java
051c520b4cb4cc1046dc316dfc8e1c968fc4e8e4
src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java
52041b5bc6e7b89616f5ce501eb22c58a12eaf26
Diff: https://reviews.apache.org/r/58017/diff/1/
Testing
-------
Thanks,
Zameer Manji
