----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58054/#review170516 -----------------------------------------------------------
Ship it! src/main/python/apache/aurora/client/cli/diff_formatter.py Line 55 (original), 55 (patched) <https://reviews.apache.org/r/58054/#comment243369> Please leave a comment that we are sorting sets here for consistency. - Zameer Manji On March 29, 2017, 8:29 p.m., Santhosh Kumar Shanmugham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58054/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 8:29 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Bugs: AURORA-1913 > https://issues.apache.org/jira/browse/AURORA-1913 > > > Repository: aurora > > > Description > ------- > > Sort the entires in `set` fields inside `TaskConfig` as strings before > shelling out to diff so that the output is consistent and meaningful. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/diff_formatter.py > a1b9bb3086b277e5da6d21496879a7aca8299e00 > src/test/python/apache/aurora/client/cli/test_diff_formatter.py > a145d8846f65ba222d7fd3f91bf9109a50f26314 > src/test/python/apache/aurora/client/cli/util.py > c65ae75c680ec4ca4e4d2a398c80e73ddff16649 > > > Diff: https://reviews.apache.org/r/58054/diff/1/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Santhosh Kumar Shanmugham > >
