-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58366/#review171629
-----------------------------------------------------------
Master (cc2aa46) is red with this patch.
./build-support/jenkins/build.sh
[1m mock_dump_runner_pex =
create_autospec(spec=dump_runner_pex)[0m
[1m mock_dump_runner_pex.return_value = Mock()[0m
[1m mock_options = Mock()[0m
[1m mock_options.execute_as_user = False[0m
[1m mock_options.nosetuid = False[0m
[1m mock_options.announcer_ensemble = None[0m
[1m with patch([0m
[1m
'apache.aurora.executor.bin.thermos_executor_main.dump_runner_pex',[0m
[1m return_value=mock_dump_runner_pex):[0m
[1m with patch([0m
[1m
'apache.aurora.executor.bin.thermos_executor_main.DefaultThermosTaskRunnerProvider',[0m
[1m return_value=mock_runner_provider) as
mock_provider:[0m
[1m [0m
[1m expected_path =
os.path.join(os.path.abspath('.'), MesosPathDetector.DEFAULT_SANDBOX_PATH)[0m
[1m> thermos_executor =
initialize(mock_options)[0m
src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py:45:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.pants.d/python-setup/chroots/ded72a92f42d51a353c9a611aac3451e5b49db17/apache/aurora/executor/bin/thermos_executor_main.py:237:
in initialize
[1m process_collection_interval =
Amount(options.task_process_collection_interval_secs, Time.SECONDS)[0m
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <[AttributeError("'Amount' object has no attribute
'_amount'") raised in repr()] SafeRepr object at 0x7f8f21629758>
amount = <Mock
name='mock.task_process_collection_interval_secs' id='140252715284688'>
unit = <twitter.common.quantity.Time object at
0x7f8f22efd690>
[1m def __init__(self, amount, unit):[0m
[1m if not isinstance(amount, Integral):[0m
[1m> raise ValueError('Amount should be an integer
type.')[0m
[1m[31mE ValueError: Amount should be an integer
type.[0m
.pants.d/python-setup/chroots/ded72a92f42d51a353c9a611aac3451e5b49db17/.deps/twitter.common.quantity-0.3.7-py2-none-any.whl/twitter/common/quantity/__init__.py:87:
ValueError
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/aaf4d108c31293299a0839bdc404a91802f80937.xml
[1m[31m 1 failed, 781 passed, 6 skipped, 1 warnings in
318.59 seconds [0m
FAILURE
20:33:45 05:54 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On April 11, 2017, 8:20 p.m., David Robinson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58366/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 8:20 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1918
> https://issues.apache.org/jira/browse/AURORA-1918
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow resource monitors to be disabled.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py
> c6c08983fb2d204afedd419798135d667169bce4
> src/main/python/apache/thermos/monitoring/resource.py
> 434666696e600a0e6c19edd986c86575539976f2
>
>
> Diff: https://reviews.apache.org/r/58366/diff/1/
>
>
> Testing
> -------
>
> Tested -thermos_executor_flags="--task_disk_collection_interval_secs=0
> --task_process_collection_interval_secs=0" (and different combinations: disk
> enabled and process disabled, disk disabled and process enabled, both
> enabled, both disabled). Launched various jobs and ensured the specific
> resource monitors were enabled or disabled as per the executor flags.
>
>
> Thanks,
>
> David Robinson
>
>
