----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57433/#review172218 -----------------------------------------------------------
Any news on this, or your testing of the new curator implementation? Is the curator implementation good enough so that this ticket can be discarded and the legacy ZK implementation be dropped? - Stephan Erb On March 8, 2017, 10:55 p.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57433/ > ----------------------------------------------------------- > > (Updated March 8, 2017, 10:55 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Bugs: AURORA-1895 > https://issues.apache.org/jira/browse/AURORA-1895 > > > Repository: aurora > > > Description > ------- > > This patch expose stats on the connection state of the `ZooKeeperClient` in > `CommonsServiceDiscoveryModule`. This is done through the ZooKeeper client > `Watcher` interface. > > We have previously exposed ZooKeeper stats for > `CuratorServiceDiscoveryModule` (AURORA-1838). > > Currently `FakeStatsProvider` is placed under `aurora` module. It needs to be > moved over to `commons` for tests to be written against `FakeStatsProvider` > insteads of `Stats`. I can address that in a separate review board. > > > Diffs > ----- > > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java > ce243fb44266b741ff3f14eb5438ff38cf46133f > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java > ba09279be9d8bfde79b7610a184bb472ab0396b5 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java > 5eee235162e938ecdfdb7d3c4d31d848a34a648b > > src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule.java > 339f63b94e996e13514e6a6dcd7bbeef3a0f09f8 > > > Diff: https://reviews.apache.org/r/57433/diff/2/ > > > Testing > ------- > > ``` > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ... > *** OK (All tests passed) *** > > mesos-master start/running, process 3166 > + RETCODE=0 > + restore_netrc > + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc > + true > Connection to 127.0.0.1 closed. > > real 29m46.212s > user 0m1.468s > sys 0m0.783s > ``` > > ``` > url localhost:8081/vars | grep zk_connection_state > % Total % Received % Xferd Average Speed Time Time Time > Current > Dload Upload Total Spent Left Speed > 100 38251 0 38251 0 0 208k 0 --:--:-- --:--:-- --:--:-- 208k > zk_connection_state_AuthFailed 0 > zk_connection_state_AuthFailed_counter 0 > zk_connection_state_ConnectedReadOnly 0 > zk_connection_state_ConnectedReadOnly_counter 0 > zk_connection_state_Disconnected 0 > zk_connection_state_Disconnected_counter 0 > zk_connection_state_Expired 0 > zk_connection_state_Expired_counter 0 > zk_connection_state_NoSyncConnected 0 > zk_connection_state_NoSyncConnected_counter 0 > zk_connection_state_SaslAuthenticated 0 > zk_connection_state_SaslAuthenticated_counter 0 > zk_connection_state_SyncConnected 1 > zk_connection_state_SyncConnected_counter 1 > zk_connection_state_Unknown 0 > zk_connection_state_Unknown_counter 0 > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
