----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58609/#review172657 -----------------------------------------------------------
src/main/python/apache/aurora/executor/thermos_task_runner.py Line 257 (original), 257 (patched) <https://reviews.apache.org/r/58609/#comment245722> I think a better place to do this might be in [thermos_runner.py](https://github.com/apache/aurora/blob/master/src/main/python/apache/thermos/runner/thermos_runner.py). Instead of passing this as a command line arg, we could just: from twitter.common.log.options import LogOptions LogOptions.set_simple(True) (We already do this in our internal fork, no idea why it's done there instead of the main project) - Joshua Cohen On April 21, 2017, 9:35 a.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58609/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 9:35 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Switch Thermos runner to simple disk log layout. > > This collapses the individual files per loglevel. We will therefore have just > one log file for executor and one for the runner. > > -- > > Not to reviwers: I am unsure why the executor log file defaults to __main__ > rather than the name of the binary. I decided not to dig deeper here, as it > is not my main problem during operations. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/thermos_task_runner.py > 8f88af4c24ddc603fa12587741af56a6c711e420 > > > Diff: https://reviews.apache.org/r/58609/diff/1/ > > > Testing > ------- > > ./pants test.pytest src/test/python:: > > > File Attachments > ---------------- > > after.png > > https://reviews.apache.org/media/uploaded/files/2017/04/21/8816f094-b473-45bd-8d9a-fd2f3fad7dfe__after.png > before.png > > https://reviews.apache.org/media/uploaded/files/2017/04/21/f10b3500-a66b-4850-a571-f964b97b7b40__before.png > > > Thanks, > > Stephan Erb > >
