----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58636/#review172861 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java Lines 96-101 (patched) <https://reviews.apache.org/r/58636/#comment245877> Just noticed this is going to read like: preemption_slot_cache_size_removals preemption_slot_cache_size_explicit_removals etc. We'd probably just want a name of the cache (preemption_slot_cache) and then add the suffixes. - David McLaughlin On April 24, 2017, 9:38 p.m., Reza Motamedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58636/ > ----------------------------------------------------------- > > (Updated April 24, 2017, 9:38 p.m.) > > > Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, and > Santhosh Kumar. > > > Repository: aurora > > > Description > ------- > > - adding metrics for removals from bicache > > I updated this patch according to the nicer implementaion on an older RB from > @mehrdad: https://reviews.apache.org/r/55027. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java > 70390f6b1ead322ebe3dd5d625dad44b70e2d185 > src/test/java/org/apache/aurora/scheduler/preemptor/BiCacheTest.java > bac8f3348fd7f369a60f6a492fa2d996e4c47b44 > > > Diff: https://reviews.apache.org/r/58636/diff/2/ > > > Testing > ------- > > ``` > # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:bicache-metrics ? [16:22:23] > ? ./build-support/jenkins/build.sh > > . > .. > ... > > Executing tasks in goals: setup-py > 16:22:16 00:00 [setup-py] > 16:22:16 00:00 [setup-py] > Creating setup.py project for > PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/kerberos/BUILD, > FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), kerberos)) > Creating setup.py project for > PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/common/BUILD, > FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), common)) > Creating setup.py project for > PythonLibrary(BuildFileAddress(BuildFile(api/src/main/thrift/org/apache/aurora/gen/BUILD, > FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), gen)) > Creating setup.py project for > PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/admin/BUILD, > FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), admin)) > Creating setup.py project for > PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/client/BUILD, > FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), client)) > Creating setup.py project for > PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/aurora/config/BUILD, > FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), config)) > Creating setup.py project for > PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/thermos/config/BUILD, > FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), config)) > Creating setup.py project for > PythonLibrary(BuildFileAddress(BuildFile(src/main/python/apache/thermos/common/BUILD, > FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), common)) > Creating setup.py project for > PythonThriftLibrary(BuildFileAddress(BuildFile(api/src/main/thrift/org/apache/thermos/BUILD, > FileSystemProjectTree(/Users/rmotamedi/oss/aurora)), thermos)) > Running packager against > /Users/rmotamedi/oss/aurora/dist/apache.thermos.thrift-0.18.0-SNAPSHOT > Writing > /Users/rmotamedi/oss/aurora/dist/apache.thermos.thrift-0.18.0-SNAPSHOT.tar.gz > Running packager against > /Users/rmotamedi/oss/aurora/dist/apache.aurora.thrift-0.18.0-SNAPSHOT > Writing > /Users/rmotamedi/oss/aurora/dist/apache.aurora.thrift-0.18.0-SNAPSHOT.tar.gz > Running packager against > /Users/rmotamedi/oss/aurora/dist/apache.thermos.common-0.18.0-SNAPSHOT > Writing > /Users/rmotamedi/oss/aurora/dist/apache.thermos.common-0.18.0-SNAPSHOT.tar.gz > Running packager against > /Users/rmotamedi/oss/aurora/dist/apache.thermos.config-0.18.0-SNAPSHOT > Writing > /Users/rmotamedi/oss/aurora/dist/apache.thermos.config-0.18.0-SNAPSHOT.tar.gz > Running packager against > /Users/rmotamedi/oss/aurora/dist/apache.aurora.common-0.18.0-SNAPSHOT > Writing > /Users/rmotamedi/oss/aurora/dist/apache.aurora.common-0.18.0-SNAPSHOT.tar.gz > Running packager against > /Users/rmotamedi/oss/aurora/dist/apache.aurora.config-0.18.0-SNAPSHOT > Writing > /Users/rmotamedi/oss/aurora/dist/apache.aurora.config-0.18.0-SNAPSHOT.tar.gz > Running packager against > /Users/rmotamedi/oss/aurora/dist/apache.aurora.client-0.18.0-SNAPSHOT > Writing > /Users/rmotamedi/oss/aurora/dist/apache.aurora.client-0.18.0-SNAPSHOT.tar.gz > Running packager against > /Users/rmotamedi/oss/aurora/dist/apache.aurora.admin-0.18.0-SNAPSHOT > Writing > /Users/rmotamedi/oss/aurora/dist/apache.aurora.admin-0.18.0-SNAPSHOT.tar.gz > Running packager against > /Users/rmotamedi/oss/aurora/dist/apache.aurora.kerberos-0.18.0-SNAPSHOT > Writing > /Users/rmotamedi/oss/aurora/dist/apache.aurora.kerberos-0.18.0-SNAPSHOT.tar.gz > 16:22:23 00:07 [complete] > SUCCESS > ``` > > > Thanks, > > Reza Motamedi > >
