> On April 25, 2017, 7:30 p.m., Zameer Manji wrote: > > I noticed this too. I would also support bumping it to 30s as well.
I thought about this as well but was unsure if it really helps. Most of the time stuff will quit instantly on SIGTERM or only die at the hard SIGKILL after one minute. Let's just see how this patch works for now. We can follow-up with a second one if necessary. - Stephan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58611/#review172951 ----------------------------------------------------------- On April 21, 2017, 12:36 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58611/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 12:36 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > It is not very common that kills are dropped by Mesos and have to be retried > by Aurora. It therefore makes sense to slightly increase the retry timeout > so that we don't retry needlessly when Thermos is still busy executing > the lifecycle methods. > > By default, Thermos uses the following kill escalation sequence: > > * /quitquitquit > * wait 5s > * /abortabortabort > * wait 5s > * SIGTERM > * wait up to 1 minute > * SIGKILL > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java > e076e802f8920b37cef202520c7fbe59724dd06d > > > Diff: https://reviews.apache.org/r/58611/diff/1/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
