-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174694
-----------------------------------------------------------
Master (b0d24f4) is red with this patch.
./build-support/jenkins/build.sh
virtualenv-15.0.2/virtualenv_support/__init__.py
virtualenv-15.0.2/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/setuptools-21.2.1-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl
+ touch virtualenv-15.0.2/BOOTSTRAPPED
+ popd
/home/jenkins/jenkins-slave/workspace/AuroraBot
+ exec /usr/bin/python2.7
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-15.0.2/virtualenv.py
--no-download
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv
New python executable in
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7
Also creating executable in
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python
Installing setuptools, pip, wheel...done.
Collecting isort==4.0.0
Downloading isort-4.0.0-py2.py3-none-any.whl
Installing collected packages: isort
Successfully installed isort-4.0.0
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
ERROR:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/task.py
Imports are incorrectly sorted.
---
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/task.py:before
2017-05-11 17:46:29.148758
+++
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/task.py:after
2017-05-11 17:51:30.112057
@@ -31,16 +31,16 @@
from apache.aurora.client.cli.context import AuroraCommandContext
from apache.aurora.client.cli.options import (
ALL_INSTANCES,
- CommandOption,
EXECUTOR_SANDBOX_OPTION,
INSTANCES_SPEC_ARGUMENT,
+ SCP_DEST_ARGUMENT,
SCP_OPTIONS,
SCP_SOURCE_ARGUMENT,
- SCP_DEST_ARGUMENT,
SSH_INSTANCE_ARGUMENT,
SSH_OPTIONS,
SSH_USER_OPTION,
TASK_INSTANCE_ARGUMENT,
+ CommandOption,
parse_task_instance_key
)
from apache.aurora.common.clusters import CLUSTERS
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On May 11, 2017, 5:13 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 5:13 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh
> Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox
> of a task instance.
>
> This command essentially mimics scp but expands task instances into their
> respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt
> cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp
> cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp
> cluster/role/env/job/instance:/test.txt
> cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py
> 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py
> 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py
> 390993fc55d7aa717f39e25375b2d6cfe96242d0
>
>
> Diff: https://reviews.apache.org/r/59163/diff/1/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts
> ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 --
> pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py
> ........
> src/test/python/apache/aurora/client/cli/test_version.py
> .
> src/test/python/apache/aurora/client/cli/test_quota.py
> .....
> src/test/python/apache/aurora/client/cli/test_plugins.py
> .
> src/test/python/apache/aurora/client/cli/test_client.py
> ..
> src/test/python/apache/aurora/client/cli/test_sla.py
> .....
> src/test/python/apache/aurora/client/cli/test_open.py
> .....
> src/test/python/apache/aurora/client/cli/test_supdate.py
> .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py
> ..........
> src/test/python/apache/aurora/client/cli/test_status.py
> .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py
> ..........
>
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py
> ......
> src/test/python/apache/aurora/client/cli/test_task.py
> ...........
> src/test/python/apache/aurora/client/cli/test_create.py
> ..............
> src/test/python/apache/aurora/client/cli/test_kill.py
> ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py
> ....
>
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
>
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the
> command to transfer a text file between the scheduler machine and job I
> created.
>
>
> Thanks,
>
> Jordan Ly
>
>