----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59039/#review174790 -----------------------------------------------------------
Fix it, then Ship it! The patch looks good. However, my guice knowledge is spotty at best. src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java Lines 81 (patched) <https://reviews.apache.org/r/59039/#comment248015> How does this look like on the commandline? Do I have to provide a fully-specified class name here? src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java Line 130 (original), 174 (patched) <https://reviews.apache.org/r/59039/#comment248013> Changes like these and others in this patch could potentially break our benchmarking scripts. Could you please make sure that at least the `SchedulingBenchmarks` continue to run? We already have several broken the benchmarks suites `ThriftApiBenchmarks`, `SnapshotBenchmarks` `StatusUpdateBenchmark` and `ThriftApiBenchmarks`. Would be a pitty if we break even more. src/main/java/org/apache/aurora/scheduler/state/FirstFitTaskAssignerModule.java Lines 28 (patched) <https://reviews.apache.org/r/59039/#comment248012> For consistency how about renaming `TaskAssignerImpl` to `FirstFitTaskAssignerImpl`? - Stephan Erb On May 11, 2017, 11:46 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59039/ > ----------------------------------------------------------- > > (Updated May 11, 2017, 11:46 p.m.) > > > Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Zameer > Manji. > > > Bugs: AURORA-1920 > https://issues.apache.org/jira/browse/AURORA-1920 > > > Repository: aurora > > > Description > ------- > > Add the ability to replace the first-fit scheduling algorithm and associated > first-fit preemption logic. > > See design/proposal document here: > https://docs.google.com/document/d/1fVHLt9AF-YbOCVCDMQmi5DATVusn-tqY8DldKbjVEm0/edit?usp=sharing > > > Diffs > ----- > > RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07 > docs/development/design-documents.md > c942643d6220cb61eb97289b35d92facae06a682 > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorModule.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterModule.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java > 66d20290d381c041ac2f28903d6ba1468b352172 > > src/main/java/org/apache/aurora/scheduler/state/FirstFitTaskAssignerModule.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/state/StateModule.java > 0186484208965c5b8942ec76eb078b30190c7d57 > > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java > da064e3589951d4f4cbff96d1ed89d9d7e4d3882 > > > Diff: https://reviews.apache.org/r/59039/diff/2/ > > > Testing > ------- > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > I've used this in one of our large-scale test clusters to plug in a custom > task assigner. We were able to remove our modifications to the OSS code-base > and use this mechanism to do what we need. Here is a rough gist of what it > looks like: > https://gist.github.com/DavidMcLaughlin/5d5472cde15343aef8705478f644ddb9 > > > Thanks, > > David McLaughlin > >
