-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59864/#review177239
-----------------------------------------------------------
Master (73234d0) is red with this patch.
./build-support/jenkins/build.sh
virtualenv-15.0.2/virtualenv.py
virtualenv-15.0.2/virtualenv_embedded/
virtualenv-15.0.2/virtualenv_embedded/activate.bat
virtualenv-15.0.2/virtualenv_embedded/activate.csh
virtualenv-15.0.2/virtualenv_embedded/activate.fish
virtualenv-15.0.2/virtualenv_embedded/activate.ps1
virtualenv-15.0.2/virtualenv_embedded/activate.sh
virtualenv-15.0.2/virtualenv_embedded/activate_this.py
virtualenv-15.0.2/virtualenv_embedded/deactivate.bat
virtualenv-15.0.2/virtualenv_embedded/distutils-init.py
virtualenv-15.0.2/virtualenv_embedded/distutils.cfg
virtualenv-15.0.2/virtualenv_embedded/python-config
virtualenv-15.0.2/virtualenv_embedded/site.py
virtualenv-15.0.2/virtualenv_support/
virtualenv-15.0.2/virtualenv_support/__init__.py
virtualenv-15.0.2/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/setuptools-21.2.1-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl
+ touch virtualenv-15.0.2/BOOTSTRAPPED
+ popd
/home/jenkins/jenkins-slave/workspace/AuroraBot
+ exec /usr/bin/python2.7
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-15.0.2/virtualenv.py
--no-download
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv
New python executable in
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7
Also creating executable in
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python
Installing setuptools, pip, wheel...done.
Collecting isort==4.0.0
Downloading isort-4.0.0-py2.py3-none-any.whl
Installing collected packages: isort
Successfully installed isort-4.0.0
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
ERROR:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/disk.py
Imports are incorrectly sorted.
---
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/disk.py:before
2017-06-07 22:25:22.452867
+++
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/disk.py:after
2017-06-07 22:30:27.961539
@@ -101,4 +101,4 @@
@property
def completed_event(self):
- return threading.Event()+ return threading.Event()
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On June 7, 2017, 10:24 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59864/
> -----------------------------------------------------------
>
> (Updated June 7, 2017, 10:24 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and
> Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Allow disk monitoring to be disabled in Thermos Executor
>
> related tickets:
> - https://issues.apache.org/jira/browse/AURORA-1033
> - https://issues.apache.org/jira/browse/AURORA-1918
>
> https://docs.google.com/document/d/1-1eYenw9wgsWXyyOWn32l0oJBBXpzIN5V20vi0AZpi8/edit?usp=sharing
>
> This RB is related to part(1) of the above document. As I learned recently,
> the community favors disabling the disk monitoring in the Observer as well,
> and this would be addressed in part(2). I think it is possible to keep the
> current bahavior by asking the Mesos Agent, but for sure disabling the
> monitoring is the easiest way.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py
> c6c08983fb2d204afedd419798135d667169bce4
> src/main/python/apache/aurora/executor/common/resource_manager.py
> b7dc40d8973ec2e5998ab4f6ff988051a70bb1ab
> src/main/python/apache/thermos/monitoring/disk.py
> 52c5d74fd70b5942ea3ef5101ba3f27bfc98fc21
>
>
> Diff: https://reviews.apache.org/r/59864/diff/2/
>
>
> Testing
> -------
>
> I tested this by running `./build-support/jenkins/build.sh` and it passed.
>
> I also modified
> `-thermos_executor_flags="--announcer-ensemble localhost:2181
> --announcer-zookeeper-auth-config
> /home/vagrant/aurora/examples/vagrant/config/announcer-auth.json
> --mesos-containerizer-path=/u sr/libexec/mesos/mesos-containerizer"`
> to
> `-thermos_executor_flags="--announcer-ensemble localhost:2181
> --announcer-zookeeper-auth-config
> /home/vagrant/aurora/examples/vagrant/config/announcer-auth.json
> --mesos-containerizer-path=/u sr/libexec/mesos/mesos-containerizer
> --disable-disk-monitor"`
> in `examples/vagrant/upstart/aurora-scheduler.conf` and the falg is being
> picked up and the task is executed.
>
>
> Thanks,
>
> Reza Motamedi
>
>
