-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59957/#review177518
-----------------------------------------------------------
Master (73234d0) is red with this patch.
./build-support/jenkins/build.sh
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java:38:
Note: Wrote forwarder
org.apache.aurora.scheduler.thrift.aop.MockDecoratedThriftForwarder
@Forward(AnnotatedAuroraAdmin.class)
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java:195:
Avoid unused private fields such as 'taskIdGenerator'.
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java:195:
Perhaps 'taskIdGenerator' could be replaced by a local variable.
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java:889:
Avoid unused method parameters such as 'task'.
:pmdMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':pmdMain'.
> 3 PMD rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/pmd/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 3 mins 45.925 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On June 9, 2017, 5:28 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59957/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 5:28 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1897
> https://issues.apache.org/jira/browse/AURORA-1897
>
>
> Repository: aurora
>
>
> Description
> -------
>
> To work around an old Mesos bug (MESOS-691) we would reject jobs that
> resulted in Mesos task ids longer than 255 characters. This is because Mesos
> used to use the task id to generate the cgroup path. Now Mesos uses it's own
> id, we no longer need to work around this bug.
>
> This removes the restriction in the API layer. This is useful because some
> users may have very long role and service names that caused task ids to go
> over this limit.
>
>
> Diffs
> -----
>
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
> 059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae
>
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
> 016859ca3bf83f64d2576b4c7109729770f9e25c
>
>
> Diff: https://reviews.apache.org/r/59957/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
