----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60173/#review178273 -----------------------------------------------------------
Can you show the testing from the Vagrant box? - Santhosh Kumar Shanmugham On June 19, 2017, 10:12 a.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60173/ > ----------------------------------------------------------- > > (Updated June 19, 2017, 10:12 a.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, > Stephan Erb, and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Allow for custom Thrift method interceptors to be injected via Guice modules. > Cluster operators might use this feature to inject interceptors that only > allow certain roles to call certain endpoints, or to dynamically check if a > job should be able to use a constraint. > > > Diffs > ----- > > RELEASE-NOTES.md e032f7927a68b00401ea8f073ff52b5def74f3ce > docs/reference/scheduler-configuration.md > 3d53c5a552e06f62a7572591fb0c92ccae42c54b > src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java > f59ee1a0514a6dc52573c0b932cba755e0a10e18 > > > Diff: https://reviews.apache.org/r/60173/diff/2/ > > > Testing > ------- > > Injected a custom module on a Vagrant box. > > Unit + integration tests pass. > > > Thanks, > > Jordan Ly > >
