----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60306/ -----------------------------------------------------------
(Updated June 21, 2017, 11:37 p.m.) Review request for Aurora. Changes ------- Add screenshots to illustrate the observed issue. Repository: aurora Description ------- Included changes: * Thermos may consider launched processes to be LOST. Instead of restarting those immediately, the restarts will now be at least `min_duration` seconds apart. Restarts will also be capped at the TOTAL_RUN_LIMIT of 100 restarts. This ensures neither Thermos nor the observer will be overloaded by checkpoints. The handling of the LOST state is now consistent with the handling of both FAILED and FINISHED. * Mark the success_transition and failure_transition as private. They are only used within `TaskPlanner` itself. * Fix documented default of `min_duration` (i.e 5s rather than 15s). Diffs ----- docs/reference/configuration.md 6a9a3ff988dd2102aa9d22e27f22487f18423894 src/main/python/apache/thermos/common/planner.py da5120f8f0c2489927a03e9d78ccb4f9b6eb275f src/test/python/apache/thermos/common/test_task_planner.py 132c1ec4977143b79df8d13804370e76a553c3b9 Diff: https://reviews.apache.org/r/60306/diff/1/ Testing ------- ./pants test.pytest src/test/python:: File Attachments (updated) ---------------- massive_cpu_spike.png https://reviews.apache.org/media/uploaded/files/2017/06/21/57cbc6e6-2cd5-4e92-995a-e0e05a57c359__massive_cpu_spike.png massive_restart_count.png https://reviews.apache.org/media/uploaded/files/2017/06/21/c4cbab7c-1a48-4cf0-92ab-5fa9444813c7__massive_restart_count.png Thanks, Stephan Erb
