-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61238/#review181752
-----------------------------------------------------------
Master (cdc5b8e) is red with this patch.
./build-support/jenkins/build.sh
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java:38:
Note: Wrote forwarder
org.apache.aurora.scheduler.thrift.aop.MockDecoratedThriftForwarder
@Forward(AnnotatedAuroraAdmin.class)
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java:134:
Avoid unused private fields such as 'IS_ZERO'.
:pmdMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':pmdMain'.
> 1 PMD rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/pmd/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 3 mins 9.898 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On July 28, 2017, 7:14 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61238/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 7:14 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Mauricio Garavaglia.
>
>
> Bugs: AURORA-1943
> https://issues.apache.org/jira/browse/AURORA-1943
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix preemption ordering when tasks contain different ResourceTypes
>
> I elected to remove the stream/functional style in the implementation as
> well. I didn't like the extra iterations it required (3 instead of 1).
>
>
> Diffs
> -----
>
>
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java
> 5ed578cc4c11b49f607db5f7e516d9e6022a926c
>
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
> c39b00d65c8c2f2f74c836c6117a651fb7f9cd05
>
>
> Diff: https://reviews.apache.org/r/61238/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
