This is an automatically generated e-mail. To reply, visit:
(Updated Aug. 9, 2017, 4:47 p.m.)
Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
Removed task level resource fields from the DB and the thrift-API.
To do this, a new DB migration was added. When upgrading, it just drops the
task level resource fields. When downgrading, it creates the fields again and
populates them with information from the task_resource table.
IMPORTANT: One of the python client tests is failing (test_cron_diff). This is
not serious, I think it is a problem with the ordering of the elements of
Resources (had similar problems with other python client tests that instead of
comparing the Resources as a set, compared them as lists and thus order
mattered). Nevertheless, I could not fully understand the code of that test. I
was hoping someone could give me a hand with that.
But then again, it is a smaller issue and so the patch can start being reviewed.
Issue Related: AURORA-1707
1 - Created a new VM with a fresh Aurora 0.18.0, ran the tests so that the db
would have something. Then upgraded to patched version and ran the tests again.
Everything worked and task level resource fields were no longer there.
2 - Created a new VM with a fresh patched version, ran the tests so that the db
would have something. Then downgraded to 0.18.0 and ran the tests again.
Everything worked and task level resources were there, with the correct