-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61864/#review183688
-----------------------------------------------------------
Master (aae2b0d) is red with this patch.
./build-support/jenkins/build.sh
[40] ./~/react-router-dom/es/Switch.js 49 bytes {0} [built]
[41] ./~/react-router-dom/es/matchPath.js 52 bytes {0} [built]
+ 36 hidden modules
chunk {1} src/main/js/components/__tests__/Home-test.js,
src/main/js/components/__tests__/Home-test.js.map
(src/main/js/components/__tests__/Home-test.js) 473 kB [entry] [rendered]
[0] ./~/preact-compat/dist/preact-compat.es.js 17.5 kB {0} {1} [built]
[1] ./~/prop-types/index.js 1.08 kB {0} {1} [built]
[3] ./~/process/browser.js 5.42 kB {0} {1} [built]
[18] ./src/main/js/components/Home.js 469 bytes {0} {1} [built]
[27] ./~/preact/dist/preact.esm.js 29.6 kB {0} {1} [built]
[29] ./~/prop-types/factoryWithThrowingShims.js 1.59 kB {0} {1} [built]
[52] ./~/chai/lib/chai.js 1.26 kB {1} [built]
[53] ./~/chai/lib/chai/config.js 2.93 kB {1} [built]
[67] ./~/chai/index.js 40 bytes {1} [built]
[68] ./~/preact-jsx-chai/dist/index.js 15 kB {1} [built]
[69] ./src/main/js/components/__tests__/Home-test.js 768 bytes {1} [built]
[72] ./~/chai/lib/chai/interface/assert.js 92.8 kB {1} [built]
[83] ./~/chai/lib/chai/utils/index.js 2.46 kB {1} [built]
[93] ./~/preact-render-to-string/dist/jsx.js 21 kB {1} [built]
[94] ./~/preact-render-to-string/jsx.js 63 bytes {1} [built]
+ 41 hidden modules
webpack: Compiled successfully.
[32m23 08 2017 23:47:40.961:INFO [karma]: [39mKarma v1.7.0 server started at
http://0.0.0.0:9876/
[32m23 08 2017 23:47:40.963:INFO [launcher]: [39mLaunching browser PhantomJS
with unlimited concurrency
[31m23 08 2017 23:47:40.965:ERROR [launcher]: [39mCannot load browser
"PhantomJS": it is not registered! Perhaps you are missing some plugin?
[31m23 08 2017 23:47:40.966:ERROR [karma]: [39mFound 1 load error
npm ERR! Test failed. See above for more details.
:ui:npm_test FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':ui:npm_test'.
> Process 'command
> '/home/jenkins/jenkins-slave/workspace/AuroraBot/ui/.gradle/nodejs/node-v6.9.1-linux-x64/bin/npm''
> finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 6 mins 33.468 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Aug. 23, 2017, 4:39 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61864/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2017, 4:39 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kai Huang, Santhosh Kumar
> Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bootstrap the build pipeline for new Preact UI. Obviously due to the
> disappointing decision by Facebook to keep their PATENTS clause, we can no
> longer use React or jest or any of the other Facebook OSS projects.
> Thankfully Preact has a compatibility layer that mostly hides this (see
> code), so it's really only jest (which is so much simpler than Karma) that is
> missed here.
>
> Right now we only insert a "Hello, World" message under a new path in the
> Scheduler. The goal here is to verify that this works in the Apache
> infrastructure, and that people can download the patch and confirm their
> local development environment is built correctly by gradle. Will be
> particularly useful if you don't have any of the modern Node/UI stack
> installed, because the idea is that Gradle will do it all for you.
>
> Note: this will add time, perhaps significant time, to the Scheduler build
> process the first time it sets up the environment. I've made sure to set up
> input/output directories in Gradle to make sure the UP-TO-DATE mechanism is
> respected and the work isn't repeated.
>
> The following tasks become available:
>
> ./gradlew ui:install (runs npm install and fetches 3rd party JS dependencies)
> ./gradlew ui:webpack (the main build step - performed by webpack)
> ./gradlew ui:test (runs Karma-Jasmine-Webpack-Chai powered test suite)
> ./gradlew ui:lint (runs eslint on the source code)
>
> And all of these are now performed as part of the root ./gradlew build step.
> This also maintains feature parity with ./gradlew processResources
> --continuous.
>
> This is the first time I've ever really had to do significant changes to our
> Gradle build, so any feedback on my changes there are particularly
> appreciated.
>
>
> Diffs
> -----
>
> .gitignore b4e2bcbef6fdb1c049acda7c4fda4bd47988bea2
> build.gradle c2c402f3ed0043b1e9befb6f9c4423649ee5c105
> settings.gradle b097e2fd958fa0ce6076fc104eb3890c4029295d
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
> f7e72e77e50680d937d727cb4c0eb8940aabf03b
> src/main/resources/scheduler/assets/scheduler/new-index.html PRE-CREATION
> ui/.babelrc PRE-CREATION
> ui/.eslintrc PRE-CREATION
> ui/karma.conf.js PRE-CREATION
> ui/package.json PRE-CREATION
> ui/src/main/js/components/Home.js PRE-CREATION
> ui/src/main/js/components/__tests__/Home-test.js PRE-CREATION
> ui/src/main/js/index.js PRE-CREATION
> ui/webpack.config.js PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61864/diff/1/
>
>
> Testing
> -------
>
> The Scheduler is running in my Vagrant image with the Hello World message
> served under /beta.
>
>
> Thanks,
>
> David McLaughlin
>
>
