-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61918/#review184201
-----------------------------------------------------------
Master (364eac5) is red with this patch.
./build-support/jenkins/build.sh
[21] ./~/react-router-dom/es/Route.js 128 bytes {0} [built]
[26] ./~/react-router-dom/es/index.js 925 bytes {0} [built]
[27] ./src/main/js/index.js 1.75 kB {0} [built]
[38] ./~/preact/dist/preact.esm.js 29.6 kB {0} [built]
[43] ./~/react-router-dom/es/HashRouter.js 2.38 kB {0} [built]
[44] ./~/react-router-dom/es/MemoryRouter.js 149 bytes {0} [built]
[46] ./~/react-router-dom/es/Prompt.js 131 bytes {0} [built]
[47] ./~/react-router-dom/es/Redirect.js 137 bytes {0} [built]
[48] ./~/react-router-dom/es/StaticRouter.js 149 bytes {0} [built]
[49] ./~/react-router-dom/es/Switch.js 131 bytes {0} [built]
[50] ./~/react-router-dom/es/matchPath.js 140 bytes {0} [built]
+ 43 hidden modules
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:checkstyleMain[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java:28:8:
Unused import - com.google.common.collect.ImmutableSet. [UnusedImports]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 2 mins 41.274 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Aug. 30, 2017, 9:24 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61918/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2017, 9:24 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Dmitry Zhuk, Santhosh Kumar
> Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Currently, `getOffers` and `getWeaklyConsistentOffers` provide iterables that
> use lambdas (in filter) not backed by concurrent data structures
> (`globallyBannedOffers` and `staticallyBannedOffers`). This can lead to a
> race condition where we have unknown behavior if reading and modification
> happens at the same time.
>
> To fix this, in `getOffers` we will revert to the previous behavior (before
> patch https://reviews.apache.org/r/61804/) where we create a copy of the
> current offers as well as a copy of the banned offers for consistency.
>
> For `getWeaklyConsistentOffers`, we will use concurrent data structures for
> `globallyBannedOffers` and `staticallyBannedOffers` so we don't have a race
> that may produce unknown side effects.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java
> 5697d2e2eb001042511924442ff2dbe358451642
>
>
> Diff: https://reviews.apache.org/r/61918/diff/4/
>
>
> Testing
> -------
>
> Unit tests pass.
>
> Currently running end to end test and testing on a live cluster.
>
>
> Thanks,
>
> Jordan Ly
>
>
