----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62621/#review186439 -----------------------------------------------------------
Ship it! Ship It! - Bill Farner On Sept. 27, 2017, 10:11 a.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62621/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 10:11 a.m.) > > > Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Bill > Farner. > > > Repository: aurora > > > Description > ------- > > - Allow transitions from any state to STOPPED in CallOrderEnforcingStorage, > including adding a STOPPED -> STOPPED transition so stop() can be used > idempotent. > - Use the StateMachines.checkState method (I wasn't sure if the current > checkInState was designed for anything other than throwing a > TransientStorageException) > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java > 2a5ec9c912979811c4badeee9362c22184d9cbbf > > > Diff: https://reviews.apache.org/r/62621/diff/1/ > > > Testing > ------- > > No unit tests specified. > ./gradlew test > > > Thanks, > > Jordan Ly > >