----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62620/#review186443 -----------------------------------------------------------
Ship it! Ship It! - Jordan Ly On Sept. 27, 2017, 4:06 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62620/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 4:06 p.m.) > > > Review request for Aurora and David McLaughlin. > > > Repository: aurora > > > Description > ------- > > A few things going on here: > - when running `LocalSchedulerMain`, a binding was missing for > `@HydrateSnapshotFields Set<String>` > - `ClusterSimulatorModule` was binding `Set<Offer>` from the > `org.apache.mesos.v1` package, but the consumer was using `org.apache.mesos`. > Ouch - be on the lookout for this! > - I added a hack to make guice binding errors less awful. I'd like to work > through the tangle of deps to get us to guice 4 soon and make this situation > better. [History](https://github.com/google/guice/issues/757) for those > interested. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 3fbe99c4f1af1f11403bf08155bb4be028132e38 > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java > 7a342bd82063922ad622237168a4aae76172359f > > src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java > 963e4dc97845f96554d74df633b49c26341468fa > > > Diff: https://reviews.apache.org/r/62620/diff/1/ > > > Testing > ------- > > `./gradlew run` works > > > Thanks, > > Bill Farner > >
