----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62652/#review186523 -----------------------------------------------------------
Master (7c78519) is red with this patch. ./build-support/jenkins/build.sh :testClasses :compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processJmhResources NO-SOURCE :jmhClasses :checkstyleJmh :checkstyleMain :checkstyleTest[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:16:8: Unused import - java.net.InetSocketAddress. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:18:8: Unused import - com.google.common.base.Optional. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:19:8: Unused import - com.google.common.collect.ImmutableList. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:20:8: Unused import - com.google.inject.AbstractModule. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:22:8: Unused import - com.google.inject.Guice. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:23:8: Unused import - com.google.inject.Injector. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:26:8: Unused import - org.apache.aurora.common.quantity.Amount. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:27:8: Unused import - org.apache.aurora.common.quantity.Time. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:28:8: Unused import - org.apache.aurora.common.stats.StatsProvider. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:30:8: Unused import - org.apache.aurora.common.zookeeper.Credentials. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:31:8: Unused import - org.apache.aurora.common.zookeeper.SingletonService. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:32:8: Unused import - org.apache.aurora.common.zookeeper.ZooKeeperUtils. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:33:8: Unused import - org.apache.aurora.scheduler.app.ServiceGroupMonitor. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:34:8: Unused import - org.apache.aurora.scheduler.testing.FakeStatsProvider. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:35:8: Unused import - org.junit.Test. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:37:15: Unused import - org.junit.Assert.assertNotNull. [UnusedImports] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java:39: File contains a sequence of empty lines. [RegexpMultiline] FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleTest'. > Checkstyle rule violations were found. See the report at: > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/test.html * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. * Get more help at https://help.gradle.org BUILD FAILED in 2m 56s 38 actionable tasks: 32 executed, 6 up-to-date I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 28, 2017, 11:14 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62652/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2017, 11:14 a.m.) > > > Review request for Aurora, David McLaughlin and John Sirois. > > > Repository: aurora > > > Description > ------- > > This is the result removing the deprecated `-zk_use_curator` arg in > `FlaggedZooKeeperConfig.java`, and following the trail of unused code. > Thanks for the clean separation, John! > > > Diffs > ----- > > RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90 > commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java > df469efac2d994517d9b931cb2c1582e09d0cab7 > commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java > 75c1b1493eb178ea035a0e60f20df694626c7f50 > commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java > 98b5ee4690482683526f2e8ce4c965ed052b0232 > commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java > 2720dd13a3cc5e39f7242664fbe98f00fb75eb08 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java > aeea02d81faa3c8841edb9002498515dd0b52242 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > ace4980d3e15dc830fea48b83f0688347c71d900 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java > 01a54a5718388df7f02992388653d7b049422787 > > commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java > d9978a926e05e4303a168c7c51ee226a7dc94336 > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java > ce243fb44266b741ff3f14eb5438ff38cf46133f > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java > 2ada2646da7bdc3276803336cc638e23b9e61d26 > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java > ba09279be9d8bfde79b7610a184bb472ab0396b5 > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java > 29204cda66343c5b3c80d167eccd36abfb6ee641 > > commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java > 9c0cebe888d966fd64d17778c354136df0e13c7e > commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java > 97a42d1bd6c60598d7936a2c065e163c1505ef3d > commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java > 2166123e9acd701e55e10b450a9eb89054c7afdd > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > f0c0cb4491c7b5c34103864ee244a27db3972a94 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java > 0e6719154ee5195111db51d323fa35c3bc56ec2b > > commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java > 5f6cdd83ca6c6338f8c7a0a3c93b960c036cb05e > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java > 5eee235162e938ecdfdb7d3c4d31d848a34a648b > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java > 9e482a6162abe5f9864d0ca0094cd97dc8036496 > > src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule.java > 339f63b94e996e13514e6a6dcd7bbeef3a0f09f8 > > src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitor.java > 9161455c3101fb0d83633883a67ce0ffe22fcdf8 > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java > ea167a89a95f0f35d53a34631ae44e0a911a6817 > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java > e8aafe4a47e3f0e6312c8b93dbc32e1c25445dd3 > > src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java > 917a5679699581fb345d51d2837f372411d4beda > src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java > 4014a91299d863337c5f58a0495775c5f4aa6c09 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > a7c9c83eebbbea7ae8a6c807f98d3ce8bd050137 > > src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java > 0f2121ef1453b41286f9713d5ce89a26d1cb1b4f > > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java > 226b0686f91539decd7d421a28d431209bcec790 > > src/test/java/org/apache/aurora/scheduler/discovery/CommonsDiscoveryModuleTest.java > 7a4c4dd932fa0a69f22bcbb5cba7750bba52e16d > > src/test/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitorTest.java > 42a2224839f00e6938100fc315874c531cb37096 > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorDiscoveryModuleTest.java > f1a02e4becc5865e72aaf96334c53cb9c395d09a > > src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java > a065505134c1ad30ba9f4d4cd829355b2acc9a13 > src/test/java/org/apache/aurora/scheduler/http/LeaderHealthTest.java > d21a38ed66253eb7a2ceefaf6c0ec1b788036552 > > > Diff: https://reviews.apache.org/r/62652/diff/1/ > > > Testing > ------- > > `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` > > > Thanks, > > Bill Farner > >
