----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review186687 -----------------------------------------------------------
Master (7a80373) is red with this patch. ./build-support/jenkins/build.sh :startScripts :distTar :distZip :assemble :compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java:38: Note: Wrote forwarder org.apache.aurora.scheduler.thrift.aop.MockDecoratedThriftForwarder @Forward(AnnotatedAuroraAdmin.class) ^ Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processTestResources :testClasses :compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processJmhResources NO-SOURCE :jmhClasses :checkstyleJmh :checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/AppModule.java:108: Line has trailing spaces. [RegexpSingleline] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/AppModule.java:108: Line is longer than 100 characters (found 102). [LineLength] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/AppModule.java:110:71: '=' is not preceded with whitespace. [WhitespaceAround] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java:191: Line is longer than 100 characters (found 105). [LineLength] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java:212: Line is longer than 100 characters (found 113). [LineLength] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java:212:17: 'static' modifier out of order with the JLS suggestions. [ModifierOrder] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java:213:17: 'static' modifier out of order with the JLS suggestions. [ModifierOrder] FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleMain'. > Checkstyle rule violations were found. See the report at: > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. * Get more help at https://help.gradle.org BUILD FAILED in 3m 37s 37 actionable tasks: 31 executed, 6 up-to-date I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 29, 2017, 4:44 p.m., Mauricio Garavaglia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62692/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2017, 4:44 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > Moves the job environment validation to the scheduler, which can be enabled > with the scheduler require_predefined_environments flag. This allows to have > a consistent behavior when using the CLI and the API. In order to preserve > backward compatibility, the validation is kept in the CLI and for the API it > needs to be manually enabled in the scheduler. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > 081dff2bda626f01ba222628b8d7d8afebbb0004 > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 186fa1b3a4780c0536fb486d50a33133258110cd > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > 754fde0fdc976b673d78ae15d8ccd8c85b792373 > src/main/python/apache/aurora/client/config.py > 70c2c980309e18de576b251087cdfea00ac06b75 > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > 50d7499f4332a3feb0e2301cb707f2cea6bb2e98 > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > 6b4b17f8dafd5c2d751dcda3080b476335f8aec0 > > > Diff: https://reviews.apache.org/r/62692/diff/1/ > > > Testing > ------- > > > Thanks, > > Mauricio Garavaglia > >
