-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62692/#review186783
-----------------------------------------------------------
Master (24d2caf) is red with this patch.
./build-support/jenkins/build.sh
Running setup.py bdist_wheel for twitter.common.log: finished with status
'done'
Stored in directory:
/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/80/e3/3a/297d8950fcbd822ab5a6a62175818fab38b668cc5a86dbd0b0
Running setup.py bdist_wheel for pycparser: started
Running setup.py bdist_wheel for pycparser: finished with status 'done'
Stored in directory:
/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/95/14/9a/5e7b9024459d2a6600aaa64e0ba485325aff7a9ac7489db1b6
Running setup.py bdist_wheel for twitter.common.options: started
Running setup.py bdist_wheel for twitter.common.options: finished with status
'done'
Stored in directory:
/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/17/41/80/c4811d8c1c7ca7007e520c3399872fc340f45c3a26a6a23e6a
Successfully built pantsbuild.pants twitter.common.collections setproctitle
ansicolors pathspec scandir twitter.common.dirutil psutil pystache docutils
Markdown Pygments twitter.common.confluence coverage lmdb pywatchman
twitter.common.lang twitter.common.log pycparser twitter.common.options
Installing collected packages: twitter.common.lang, twitter.common.collections,
setproctitle, setuptools, six, ansicolors, pyparsing, packaging, pathspec,
scandir, twitter.common.dirutil, psutil, requests, pystache, pex, docutils,
Markdown, Pygments, twitter.common.options, twitter.common.log,
twitter.common.confluence, monotonic, fasteners, coverage, pycparser, cffi,
lmdb, pywatchman, futures, pantsbuild.pants
Found existing installation: setuptools 21.2.1
Uninstalling setuptools-21.2.1:
Successfully uninstalled setuptools-21.2.1
Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 cffi-1.7.0
coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 lmdb-0.89
monotonic-1.3 packaging-16.7 pantsbuild.pants-1.3.0.dev3 pathspec-0.3.4
pex-1.1.16 psutil-4.3.0 pycparser-2.18 pyparsing-2.2.0 pystache-0.5.3
pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10
setuptools-30.0.0 six-1.11.0 twitter.common.collections-0.3.9
twitter.common.confluence-0.3.9 twitter.common.dirutil-0.3.9
twitter.common.lang-0.3.9 twitter.common.log-0.3.9 twitter.common.options-0.3.9
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
15:18:51 00:00 [main]
(To run a reporting server: ./pants server)
15:18:51 00:00 [setup]
15:18:51 00:00 [parse][32m
Executing tasks in goals: compile[0m
15:18:51 00:00 [compile]
15:18:51 00:00 [compile-prep-command]
15:18:51 00:00 [prep_command]
15:18:54 00:03 [compile]
15:18:54 00:03 [python-eval]
15:18:54 00:03 [pythonstyle]
15:18:54 00:03 [cache] [32m
No cached artifacts for 42 targets.[0m[32m
Invalidated 42 targets.[0m
E265:ERROR PythonFile(src/main/python/apache/aurora/client/config.py):149
block comment should start with '# '
| #TODO Deprecate the environment validation once it can be enabled in
the scheduler.
FAILURE: 1 Python Style issues found. For import order related issues, please
try `./pants fmt.isort <targets>`
15:19:17 00:26 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Sept. 30, 2017, 3:04 p.m., Mauricio Garavaglia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62692/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2017, 3:04 p.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moves the job environment validation to the scheduler, which can be enabled
> with the scheduler require_predefined_environments flag. This allows to have
> a consistent behavior when using the CLI and the API. In order to preserve
> backward compatibility, the validation is kept in the CLI and for the API it
> needs to be manually enabled in the scheduler.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/AppModule.java
> 081dff2bda626f01ba222628b8d7d8afebbb0004
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java
> 186fa1b3a4780c0536fb486d50a33133258110cd
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
> 754fde0fdc976b673d78ae15d8ccd8c85b792373
> src/main/python/apache/aurora/client/config.py
> 70c2c980309e18de576b251087cdfea00ac06b75
>
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
> 50d7499f4332a3feb0e2301cb707f2cea6bb2e98
> src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
> 6b4b17f8dafd5c2d751dcda3080b476335f8aec0
>
>
> Diff: https://reviews.apache.org/r/62692/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mauricio Garavaglia
>
>
