> On Oct. 10, 2017, 2:29 p.m., Joshua Cohen wrote: > > I'd be shocked if they've been failing for over a year. We've had three > > releases since then and the release candidate verification script runs the > > end to end tests. > > > > If I had to hazard a guess, I'd point the finger at something changing in > > curl w/ the High Sierra update? I'm running the e2e tests locally right now > > (I'm still on Sierra) to confirm they're working there. > > Joshua Cohen wrote: > Oh wait, the curl version being used is from within the Vagrant image, > not the host system. So... perhaps something changed in the curl version in > vagrant?
I was just able to verify the failure. So it's not specific to your system or host OS. It'd be interesting to bisect to see what actually caused the failure, but either way your fix lgtm. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/#review187535 ----------------------------------------------------------- On Oct. 10, 2017, 6:21 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62857/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2017, 6:21 a.m.) > > > Review request for Aurora, David McLaughlin and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > TContentAwareServlet constrains the supported Content-Type headers, > resulting in test_kerberos_end_to_end.sh failing with the error > `Unsupported Content-Type: application/x-www-form-urlencoded`, which > is the Content-Type header curl chooses when the --data-binary > argument is passed > > > Diffs > ----- > > src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh > ecb3d3f50e77b800eb0d05618c7740c42fca28c2 > > > Diff: https://reviews.apache.org/r/62857/diff/1/ > > > Testing > ------- > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > Based on what i'm seeing, it appears that these tests should have been > failing since the introduction of `TContentAwareServlet` > [0105a15](https://github.com/apache/aurora/commit/0105a15) in Aug 2016. Is > that true, or have others actually seen them passing somehow? > > > Thanks, > > Bill Farner > >
