-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62763/#review187560
-----------------------------------------------------------
Master (2df250e) is red with this patch.
./build-support/jenkins/build.sh
.pants.d/python-setup/chroots/ba32407587069aafa8e32c641525ba88361a07d7/.deps/mock-1.0.1-py2-none-any.whl/mock.py:1201:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
mocks = (<MagicMock name='geteuid' id='140151418141264'>,
<MagicMock name='setuid' id='140151418195024'>, <MagicMock
name='set...d='140151418224208'>, <MagicMock name='setgroups'
id='140151423934736'>, <MagicMock name='chown' id='140151423865744'>)
td = '/tmp/tmpmUI8jr'
some_user = pwd.struct_passwd(pw_name='jglick',
pw_passwd='*', pw_uid=1939, pw_gid=1939, pw_gecos='Jesse N. Glick',
pw_dir='/home/jglick', pw_shell='/usr/local/bin/bash')
taskpath = <apache.thermos.common.path.TaskPath object at
0x7f778bd52610>
[1m @mock.patch('os.chown')[0m
[1m @mock.patch('os.setgroups')[0m
[1m @mock.patch('os.setgid')[0m
[1m @mock.patch('os.setuid')[0m
[1m @mock.patch('os.geteuid', return_value=0)[0m
[1m def test_log_permissions_other_user(*mocks):[0m
[1m with temporary_dir() as td:[0m
[1m some_user = get_other_nonroot_user()[0m
[1m taskpath = make_taskpath(td)[0m
[1m sandbox = setup_sandbox(td, taskpath)[0m
[1m [0m
[1m p = TestProcess('process', 'echo hello world',
0, taskpath, sandbox, user=some_user.pw_name)[0m
[1m p.start()[0m
[1m
wait_for_rc(taskpath.getpath('process_checkpoint'))[0m
[1m [0m
[1m # since we're not actually root, the best we
can do is check the right things were attempted[0m
[1m stdout =
taskpath.with_filename('stdout').getpath('process_logdir')[0m
[1m stderr =
taskpath.with_filename('stderr').getpath('process_logdir')[0m
[1m> assert os.path.exists(stdout)[0m
[1m[31mE assert <function exists at
0x7f7790d1df50>('/tmp/tmpmUI8jr/.logs/process/0/stdout')[0m
[1m[31mE + where <function exists at
0x7f7790d1df50> = <module 'posixpath' from
'/usr/lib/python2.7/posixpath.pyc'>.exists[0m
[1m[31mE + where <module 'posixpath' from
'/usr/lib/python2.7/posixpath.pyc'> = os.path[0m
src/test/python/apache/thermos/core/test_process.py:264:
AssertionError
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/aaf4d108c31293299a0839bdc404a91802f80937.xml
[1m[31m 1 failed, 795 passed, 6 skipped, 1 warnings in
318.42 seconds [0m
FAILURE
17:35:22 05:54 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Oct. 10, 2017, 5:02 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62763/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2017, 5:02 p.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implement update page for new UI.
>
> The most significant change here is the performance - for our jobs at Twitter
> with thousands of instances, this shaves tens of seconds off the render time
> compared to the Angular version (which I think is attributed to the tooltip
> code).
>
> I translated the "instance events" into something useful - now grouping them
> all events for an instance together in a single item and showing history with
> the state machine component.
>
> For the instance visualization, I also simplified the color scheme. There is
> now only: success, error, warning, in progress and removed. So no more roll
> backs being represented as green boxes with red borders (roll backs are now
> considered as the warning/attention color).
>
> I didn't do much for configuration and kept the UX the same as the existing
> UI, I will tackle showing diffs in the future.
>
> This is branched off of https://reviews.apache.org/r/62720
>
>
> Diffs
> -----
>
> ui/.eslintrc 84a6d37d8a643047f97a03187fae1b3616633650
> ui/package.json 6e8ad7a3f7a5d6c450ded4e2c1f216cfa4551a2c
> ui/src/main/js/components/InstanceViz.js PRE-CREATION
> ui/src/main/js/components/Layout.js
> 50d63e6252b38cf26688ab032409a00082561f14
> ui/src/main/js/components/Pagination.js
> 7bf2c04e2b879657c6ec43d261f2512fae79a08e
> ui/src/main/js/components/TaskConfig.js PRE-CREATION
> ui/src/main/js/components/Time.js PRE-CREATION
> ui/src/main/js/components/UpdateConfig.js PRE-CREATION
> ui/src/main/js/components/UpdateDetails.js PRE-CREATION
> ui/src/main/js/components/UpdateInstanceEvents.js PRE-CREATION
> ui/src/main/js/components/UpdateInstanceSummary.js PRE-CREATION
> ui/src/main/js/components/UpdateList.js PRE-CREATION
> ui/src/main/js/components/UpdateSettings.js PRE-CREATION
> ui/src/main/js/components/UpdateStateMachine.js PRE-CREATION
> ui/src/main/js/components/UpdateStatus.js PRE-CREATION
> ui/src/main/js/components/UpdateTime.js PRE-CREATION
> ui/src/main/js/components/UpdateTitle.js PRE-CREATION
> ui/src/main/js/components/__tests__/InstanceViz-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/Pagination-test.js
> f2b72e93eabe9660f3ca54d3e151ce154fa81e0a
> ui/src/main/js/components/__tests__/UpdateInstanceEvents-test.js
> PRE-CREATION
> ui/src/main/js/components/__tests__/UpdateList-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/UpdateStatus-test.js PRE-CREATION
> ui/src/main/js/index.js 8f077341b2194fc00d202b0eb289b23986d0f2e0
> ui/src/main/js/pages/Update.js PRE-CREATION
> ui/src/main/js/pages/Updates.js PRE-CREATION
> ui/src/main/js/pages/__tests__/Update-test.js PRE-CREATION
> ui/src/main/js/pages/__tests__/Updates-test.js PRE-CREATION
> ui/src/main/js/test-utils/UpdateBuilders.js PRE-CREATION
> ui/src/main/js/utils/Common.js be8766c3b53943dcf094670019ec528975dc05b5
> ui/src/main/js/utils/Thrift.js b247e36dfa7e8b686e8e6caccfec9ff813829bab
> ui/src/main/js/utils/Update.js PRE-CREATION
> ui/src/main/js/utils/__tests__/Update-test.js PRE-CREATION
> ui/src/main/sass/app.scss e301d4c31baed10faf06d84f30d1c1dbce66952a
> ui/src/main/sass/components/_instance-viz.scss PRE-CREATION
> ui/src/main/sass/components/_layout.scss
> 4ebec0532550a0c6084fb603cfab5789c1ccb371
> ui/src/main/sass/components/_update-list.scss PRE-CREATION
> ui/src/main/sass/components/_update-page.scss PRE-CREATION
> ui/test-setup.js a403434ddd7d6b33b7e18ca8c25ab68707a35fd8
>
>
> Diff: https://reviews.apache.org/r/62763/diff/3/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
> Tested against live APIs. Note: I am pushing small nitpick bugs to the very
> end of this work (where we will leverage internal beta-testing).
>
>
> File Attachments
> ----------------
>
> Successful update
>
> https://reviews.apache.org/media/uploaded/files/2017/10/05/457b8fe0-dfd4-4e30-bbd3-e5c76906fab2__Screen_Shot_2017-10-04_at_5.22.08_PM.png
> Update In-Progress
>
> https://reviews.apache.org/media/uploaded/files/2017/10/05/d04afb4c-7110-4fe2-a0d9-c191b935a555__Screen_Shot_2017-10-04_at_5.25.40_PM.png
> Huge update
>
> https://reviews.apache.org/media/uploaded/files/2017/10/05/5b2534e3-e5d6-48e8-9615-2b1f7bb13617__Screen_Shot_2017-10-04_at_5.27.15_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
