> On Oct. 10, 2017, 10:53 p.m., Jordan Ly wrote: > > Change LGTM, but is build failing due to this change or being flaky?
Not enough memory on Jenkins :/ INFO: os::commit_memory(0x00000007b1100000, 248512512, 0) failed; error='Cannot allocate memory' (errno=12) # There is insufficient memory for the Java Runtime Environment to continue. # Native memory allocation (mmap) failed to map 248512512 bytes for committing reserved memory. # An error report file with more information is saved as: # /home/jenkins/jenkins-slave/workspace/AuroraBot/hs_err_pid2009.log I once added a hack to the Jenkins job to skip nodes with insufficient memory. Maybe it glitched here and failed to prevent the issue... - Stephan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62873/#review187586 ----------------------------------------------------------- On Oct. 10, 2017, 10:35 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62873/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2017, 10:35 p.m.) > > > Review request for Aurora and Jordan Ly. > > > Repository: aurora > > > Description > ------- > > This reduces the memory burden of loading a backup for recovery. Previously, > the backup file would be fully loaded into a `byte[]`, which may be very > large and fail to allocate. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java > b74de9b51fd01788a3970e56a534a3b9adcd8863 > > > Diff: https://reviews.apache.org/r/62873/diff/1/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >