----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/ -----------------------------------------------------------
(Updated Oct. 18, 2017, 12:16 a.m.) Review request for Aurora, Kai Huang, Santhosh Kumar Shanmugham, and Stephan Erb. Changes ------- Tweak red/green colors. Repository: aurora Description ------- Add support for Thermos configs in Diff viewer. This deserializes the opaque "data" string so that the jsonDiff algorithm creates finer grained diffs. Diffs (updated) ----- ui/src/main/js/components/Diff.js 53ba5176304bcc8d53c3964bcc7d57a20ff17e48 ui/src/main/js/components/__tests__/Diff-test.js 7f913223a3aa8ae6ce5322936e2653727481d549 ui/src/main/js/test-utils/TaskBuilders.js 8427722056917d5e3a19d64ca36bc65aa6b5b85b ui/src/main/js/utils/Task.js 7da6d1034a81afaa527ff983282a2a826b637534 ui/src/main/sass/components/_diff.scss f58f7bde33e123a50ade0026a35d880593c4274b ui/src/main/sass/components/_job-page.scss bafff882b92404f21231040c8935483f0cebfd1e Diff: https://reviews.apache.org/r/63092/diff/3/ Changes: https://reviews.apache.org/r/63092/diff/2-3/ Testing ------- ./gradlew ui:lint ./gradlew ui:test See screenshots. File Attachments ---------------- Finer grained diff https://reviews.apache.org/media/uploaded/files/2017/10/17/f9e09012-a8b1-4f18-8d70-4947f8208de0__Screen_Shot_2017-10-17_at_3.23.12_PM.png Thanks, David McLaughlin
