----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63098/#review188446 -----------------------------------------------------------
Ship it! Master (0efe415) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 18, 2017, 3:29 a.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63098/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2017, 3:29 a.m.) > > > Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > Clean up Job Page CSS. > > * Make update list smaller (was too dominant on the page). > * Show update progress/size of history. > * Tidy up whitespace. > * Move expander to end of task list item. > * Wrap the main job overview loading element in a panel group to prevent > jarring page change as content loads. > > > Diffs > ----- > > ui/src/main/js/components/TaskConfigSummary.js > 43b50d9e485d1d8c03572453c4c01a01c528ffe7 > ui/src/main/js/components/TaskList.js > 5a61de8fc46cc729906eb756c54c208320d34da7 > ui/src/main/js/components/UpdateList.js > 2df28394713d31da7d60b6b32028c16613bec3a0 > ui/src/main/js/pages/Job.js 5f92ad0b801c047f6c056623069438a5aa781c02 > ui/src/main/js/pages/__tests__/Job-test.js > 2b126b65bb09c40a528f87148942615dd035e36d > ui/src/main/sass/components/_instance-page.scss > 99204fdfca4441d824c3dfff083f78e1d094b4c9 > ui/src/main/sass/components/_task-list.scss > a6e2f0a1994134381c6d16b05209771ab2b09988 > ui/src/main/sass/components/_update-list.scss > 83a1f5a07291ea3aaabb8145877f5d7f8d8f433e > > > Diff: https://reviews.apache.org/r/63098/diff/2/ > > > Testing > ------- > > ./gradlew ui:lint > ./gradlew ui:test > > See screenshots. > > > File Attachments > ---------------- > > Tighter task list item. > > https://reviews.apache.org/media/uploaded/files/2017/10/18/8effbff4-5b1a-4883-857e-b6107ff25c6c__Screen_Shot_2017-10-17_at_8.06.09_PM.png > Job Update List > > https://reviews.apache.org/media/uploaded/files/2017/10/18/9b237777-1d3b-4eb4-94c3-cb0b332dfd95__Screen_Shot_2017-10-17_at_8.06.16_PM.png > > > Thanks, > > David McLaughlin > >
