----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63117/#review188575 -----------------------------------------------------------
Ship it! Master (b7e83a0) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 18, 2017, 8:04 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63117/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2017, 8:04 p.m.) > > > Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > Role and Environment Page fixes: > > * Remove env column on environment pages. > * Tidy up CSS that caused names to not be lined up properly with long > environment name. > * Allow you to search across job type, tier and environment. > > > Diffs > ----- > > ui/src/main/js/components/JobList.js > f54615f8cebb5ef09c1bd1e56bfff2dd5ce785f6 > ui/src/main/js/components/JobListItem.js > 5a461dd5e54b4cedab9d04f07f5fc859a37997e8 > ui/src/main/js/components/__tests__/JobList-test.js > f545c24fb545b8f3f800da8e5df3f87a65b0eb95 > ui/src/main/js/test-utils/JobBuilders.js PRE-CREATION > ui/src/main/sass/components/_job-list-page.scss > 016bff14969b6f54f9315ab09a2a6849939ddfdf > > > Diff: https://reviews.apache.org/r/63117/diff/1/ > > > Testing > ------- > > ./gradlew ui:lint > ./gradlew ui:test > > > File Attachments > ---------------- > > Screen Shot 2017-10-18 at 1.03.23 PM.png > > https://reviews.apache.org/media/uploaded/files/2017/10/18/615bce2c-1776-46cd-9f45-e991a9316c1a__Screen_Shot_2017-10-18_at_1.03.23_PM.png > > > Thanks, > > David McLaughlin > >
