----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62956/ -----------------------------------------------------------
(Updated Oct. 18, 2017, 2:25 p.m.) Review request for Aurora, David McLaughlin and Jordan Ly. Changes ------- Changed the approach in this patch to avoid disrupting other parts of the scheduler. In particular, preemption would have been impacted by rejecting 0 CPU/mem offers. Summary (updated) ----------------- When scheduling, skip offers with no CPU and no mem Repository: aurora Description ------- There's no reason for us to evaluate offers with no CPUs or memory, so reject them early in the offer lifecycle. This is an incremental performance optimization, but it may net significant improvements based on observations in some very large clusters. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/HostOffer.java bc40d0798f40003cab5bf6efe607217e4d5de9f1 src/main/java/org/apache/aurora/scheduler/http/Utilization.java 3c77e2983ce00f897f3d5ed106b779cd7f7f0940 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java 1b1239753f40d7d46d91724def6c25037eb79f1c src/main/java/org/apache/aurora/scheduler/resources/ResourceBag.java d5db81b88a0369d0b26c8fbf70efab3886ad7695 src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java e35720fca903cdcd27fff50f12ece9cc615f5d54 src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java b98aaaf48ae60afef19a368ee96abc897300f8fa src/test/java/org/apache/aurora/scheduler/HostOfferTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 2cfdc090ff75a63111ae146c9fe7b3542e7ac83f src/test/java/org/apache/aurora/scheduler/offers/Offers.java 129b4437315c6ad4ea47ca75d4ae6e28cadd7911 src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 765a527acb96997989c920be8b69dfa1113dc302 src/test/java/org/apache/aurora/scheduler/state/FirstFitTaskAssignerTest.java a74efbdc55383cd748f52cd55e1a94551d7d2ba1 Diff: https://reviews.apache.org/r/62956/diff/4/ Changes: https://reviews.apache.org/r/62956/diff/3-4/ Testing ------- Thanks, Bill Farner
