Re: Review Request 63125: Add cron configuration to Job Page

Wed, 18 Oct 2017 15:28:22 -0700 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63125/#review188598
-----------------------------------------------------------



Master (4f52f75) is red with this patch.
  ./build-support/jenkins/build.sh

                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_finish_with_daemons
 PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_finish_with_daemon_ephemerals
 PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_process_cannot_depend_upon_daemon
 PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_non_ephemeral_process_cannot_depend_on_ephemeral_process
 PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_failed_predecessor_does_not_make_process_runnable
 PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_daemon_duration
 PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_waits 
PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_fails 
PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_lost 
PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_filters 
PASSED
                     
src/test/python/apache/thermos/common/test_task_planner.py::test_task_max_runs 
PASSED
                     
src/test/python/apache/thermos/common/test_pathspec.py::test_legacy_task_roots 
PASSED
                     
src/test/python/apache/thermos/common/test_pathspec.py::test_legacy_log_dirs 
PASSED
                     
src/test/python/apache/thermos/common/test_pathspec.py::test_exception_on_none_keys
 PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_empty 
PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_unordered 
PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_ordered 
PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_mixed 
PASSED
                     
src/test/python/apache/thermos/common/test_planner.py::test_planner_unsatisfiables
 PASSED
                     
                     ==================== FAILURES ====================
                      TestTaskSucceedsIfMaxFailures0.test_runner_state_failure 
                     
                     self = <test_failure_limit.TestTaskSucceedsIfMaxFailures0 
object at 0x7fed44934e90>
                     
                         def test_runner_state_failure(self):
                     >     assert self.state.statuses[-1].state == 
TaskState.SUCCESS
                     E     assert 0 == 1
                     E      +  where 0 = TaskStatus(state=0, 
runner_uid=10025, runner_pid=21731, timestamp_ms=1508365423401).state
                     E      +  and   1 = TaskState.SUCCESS
                     
                     
src/test/python/apache/thermos/core/test_failure_limit.py:65: AssertionError
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/aaf4d108c31293299a0839bdc404a91802f80937.xml
 
                      1 failed, 795 passed, 6 skipped, 1 warnings in 
345.52 seconds 
                     
FAILURE


22:27:48 06:15   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 18, 2017, 2:40 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63125/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2017, 2:40 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adds cron configuration to Job Page.
> 
> 
> Diffs
> -----
> 
>   ui/.eslintrc f7ac075d8b0e65a2541bbee1bfd9e552f4eda95b 
>   ui/src/main/js/components/JobConfig.js 
> 275f46a88701f819007918faa3ad5a258880b308 
>   ui/src/main/js/components/TaskConfigSummary.js 
> 5c00d1e0a74a93d23b7f0e007efa6990befa6ffe 
>   ui/src/main/js/components/__tests__/JobConfig-test.js 
> 59541d9afb22de036a0076360a0e8b915548a98b 
>   ui/src/main/js/pages/Job.js 6a9bd7e5e7a2d24df0a8e5b07830485ffe718d3d 
>   ui/src/main/js/pages/__tests__/Job-test.js 
> 09dd54ec0a49f425c7de18e9bb1a1b3e7b98a624 
>   ui/src/main/js/utils/Thrift.js 4336bd1d62f145b38e667604c810436910e90b38 
>   ui/src/main/sass/components/_job-page.scss 
> cd038322ab12f5851d2e506887eddac503c62586 
>   ui/test-setup.js a86a89a0a27b335b02cf514335e6ddd8f30b23c1 
> 
> 
> Diff: https://reviews.apache.org/r/63125/diff/2/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> See screenshot.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2017-10-18 at 2.04.59 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2017/10/18/c114ecb7-7b63-4bc4-9c44-e2b2c5f479b2__Screen_Shot_2017-10-18_at_2.04.59_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Reply via email to