----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63135/ -----------------------------------------------------------
Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham. Repository: aurora Description ------- Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make them easier to write tests for (using shallow from enzyme). Also improved Pagination code (was generating a warning) now that React can handle returning null from components (and doing the right thing). Diffs ----- ui/src/main/js/components/JobHistory.js PRE-CREATION ui/src/main/js/components/JobOverview.js PRE-CREATION ui/src/main/js/components/JobStatus.js PRE-CREATION ui/src/main/js/components/Pagination.js 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8 ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81 ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION ui/src/main/js/components/__tests__/Tabs-test.js 252e5e001478b5a727e208b6b2d09d10128e83b9 ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af ui/src/main/js/pages/__tests__/Job-test.js 03ef20ddefcc915ed4bd6242de3fe8686efdc202 Diff: https://reviews.apache.org/r/63135/diff/1/ Testing ------- ./gradlew ui:lint ./gradlew ui:test Thanks, David McLaughlin
