----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63130/#review188669 -----------------------------------------------------------
Ship it! Ship It! - Stephan Erb On Oct. 19, 2017, 1:18 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63130/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2017, 1:18 a.m.) > > > Review request for Aurora, Jordan Ly and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > Enter backwards compatibility mode for LockStore. This means we will restore > and acquire locks as before, but > will ignore them otherwise. Following the next release, `LockStore` will be > removed. > > Please note that `JobUpdateController` already provides the one-at-a-time > update semantic in addition to using the legacy lock system for the same > purpose. > > This can be seen as a prerequisite for https://reviews.apache.org/r/62869/, > which will allow for a less tricky implementation of `JobUpdateStore`. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > db2220d619910ba07fdae7f04d2222cafbaa5b19 > src/main/java/org/apache/aurora/scheduler/state/LockManager.java > 2723306d61162cc8071dab9f61c7828c452dcce0 > src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java > 632d25664b2864c67b6a6c27b12895cc8b8b158f > src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java > 52c3c6618a3cf1009435ca8a9cece36365913e55 > src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java > cbe5a0deff1ebc38a9618e7d89ab073dfaf78d36 > > src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java > 222ac2d1442ede17ec088363d41b99953601ab29 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > d145259653dd4df90e3877fc3e744e24c7a15d13 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > b7d9281cc9821e5eb768becd9ab181d6c069e404 > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java > c2ec1b36a90265f73eaf66e37218af81d0a71fcf > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java > 54202359382bfe39e7cbaec0bf4c7d65d10ca13b > src/main/python/apache/aurora/client/cli/context.py > 9cf58396dc266e97f18f761d110e564ac02bb15d > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > f56ad67cbd659d99e68dd28efe1ef0a3625c08b8 > src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java > 19f9de312596395eff81bbfd073a5f617d2ef84c > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > 8fca54becde34a0d10d60e05d3809fc1c41233bf > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > b48477a61eb8e8bfa4c328a1401908ad6f4a0719 > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 453366ef4e4b6db45643b1927887771dbd795bf9 > src/test/python/apache/aurora/client/cli/test_create.py > e029ada2c69ba95b04e83bb442ccb2bdadfb2dd3 > src/test/python/apache/aurora/client/cli/test_kill.py > 269b56630f912d839410395d1ece50a37d4de05c > src/test/python/apache/aurora/client/cli/test_supdate.py > 8b90885214591060ca76fb2530f5eecaa08a2c29 > src/test/python/apache/aurora/client/cli/util.py > 43db828ca1cccd91c88f016b4c994fef33182fbf > src/test/python/apache/aurora/client/test_base.py > 691ed6791de8a7e1c4a071951e2dd170090b7522 > > > Diff: https://reviews.apache.org/r/63130/diff/1/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
