-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63199/#review188887
-----------------------------------------------------------
Master (9825e05) is red with this patch.
./build-support/jenkins/build.sh
[182] ./~/bootstrap/dist/css/bootstrap.css 984 bytes {0} [built]
[183] ./src/main/sass/app.scss 1.2 kB {0} [built]
[184] ./src/main/resources/source-sans-pro.css 1.05 kB {0} [built]
[214] ./src/main/js/index.js 3.18 kB {0} [built]
[249] ./~/react-router-dom/es/Redirect.js 137 bytes {0} [built]
+ 258 hidden modules
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processTestResources
:testClasses
:compileJmhJavaNote:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java:22:8:
Unused import - com.google.common.base.Optional. [UnusedImports]
[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java:23:8:
Unused import - com.google.common.base.Ticker. [UnusedImports]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleJmh'.
> Checkstyle rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/jmh.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 2m 35s
34 actionable tasks: 28 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Oct. 21, 2017, 5:53 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63199/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2017, 5:53 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham,
> Stephan Erb, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Using the new `hold_offers_forever` option, it is possible for the
> `staticallyBannedOffers` to grow very large in size as we never release
> offers.
>
> As an alternative to https://reviews.apache.org/r/63121/, I propose changing
> `staticallyBannedOffers` into a LRU cache which expires entries after
> `min_offer_hold_time` + `offer_hold_jitter_window` (referred to as
> `maxOfferHoldTime`), while also taking an option for a maximum size for the
> cache. I believe that this approach has a couple of benefits:
>
> 1. The current behavior of `staticallyBannedOffers` is (kinda) preserved.
> Entries will no longer be removed when the offer is used, but they will be
> removed within `maxOfferHoldTime`. This means cluster operators will not have
> to think about the new `offer_static_ban_cache_max_size` if they aren't
> affected by the memory leak now.
> 2. Cluster operators that use Aurora as a single framework and hold offers
> indefinitely can cap the size of the cache to avoid the memory leak.
> 3. Using an LRU cache greatly benefits quickly recurring crons and job
> updates.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java
> 5a9099bf9dd292249d72bc3a7604fbb3394f30ea
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java
> 7011a4cc9eea827cdd54698aaed1a653774bce7f
> src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java
> e060f2073dce4d2486d1ee2bfd873fe75167c6d0
> src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java
> e6b2c55e4f33f9a603157236766425edcaff10e7
> src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java
> 5b502442163581daa4d7954b09c00bdc3680a726
> src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java
> 6c8434e9cfe46ef63ff10c6f059ecb99981f29a2
>
>
> Diff: https://reviews.apache.org/r/63199/diff/1/
>
>
> Testing
> -------
>
> Unit tests pass.
> Deployed on a scale test cluster and saw that a) `staticallyBannedOffers`
> memory leak fixed with correct options and b) lowered assignment time for
> quickly recurring crons and rescheduled jobs.
>
>
> Thanks,
>
> Jordan Ly
>
>
