----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63236/#review189211 -----------------------------------------------------------
Ship it! Master (f2755e1) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 25, 2017, 5:01 p.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63236/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2017, 5:01 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > SchedulingFilterNotifier currently publishes veto events to be consumed by > various metadata classes (NearestFit and TaskVars). These veto events cause a > lot object allocations/async tasks. We can reduce the number of objects made > by directly calling methods and not using pubsub events. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/TaskVars.java > 676dfd9f9d7ee0633c05424f788fd0ab116976bb > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > 40579dbbd88f396d2e388a0dbed0db0a1f0bd675 > > src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java > f6c759f03c4152ae93317692fc9db202fe251122 > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java > 0637eb7f85125cf70b588d56fa7dc88130947837 > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java > 0ca7e23a8266babe673a5bdc4fd4dd51559defd7 > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java > 44cac6ff14be7ac37932434bf3e7d140b8659c59 > src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java > a4741c3fc8d233cd38596f5a794263585f44b2ae > > src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java > bf9c2b46b186125061c29ac777134a871c727066 > src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java > 90c0b8645807c6711fb7c42e9f41cb5c942bb682 > src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java > 96bddedb38fcd7d0680d0bb4a9d69d9756a05e9f > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java > e170d626e74eda07fbb026e49a5e6a78ec976bd9 > > > Diff: https://reviews.apache.org/r/63236/diff/2/ > > > Testing > ------- > > `./gradlew test` > > > Thanks, > > Jordan Ly > >
