----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63316/#review189266 -----------------------------------------------------------
Ship it! Master (5201cf1) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 25, 2017, 4:29 p.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63316/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2017, 4:29 p.m.) > > > Review request for Aurora, David McLaughlin, Stephan Erb, and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Directly call 'registered' in SchedulerLifecycle as opposed to having it be a > pubsub event. > > It is currently possible for the scheduler to register with Mesos, but have > the pubsub event stating registration was successful get drowned out by other > events (i.e. status updates). This can cause the scheduler to think that > registration was not successful and transition to a DEAD state. This > edge-case can cause the scheduler to flap, since when it comes back up it > will still get the same flood of status updates and potentially fail to > register again. > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java > 2f47a1374558afc7ede2f2da42e7ccaf3bfd7001 > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > aa09aff5fc65352111223abfc2425e8e066b9383 > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycleImpl.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 382181939d292ee00ea2071daec66aa0669609e4 > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java > 73fcdd0a7b3476a26c5383edbfef522aa65f4435 > src/main/java/org/apache/aurora/scheduler/mesos/Driver.java > be5dd45c4523e02dffb4d826df8194abb7d9064d > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java > 68d19ec53b3bb5ee02934254e8f9c82ae720c6ed > src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java > b54e1f3d427b8e99fb022536004014c3fee498d0 > src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java > e0221f8df0312c65e5403d6bfc37b76c21cc89bf > > src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java > 46090642bf21819fccd232d1202a14f5534310a8 > src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java > edd738030edf3c00e96c57dffbde4cf6b20dde41 > > src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java > 4d1a6761b8cd761d96cbfb35b0944eb524bd654f > > src/test/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverServiceTest.java > a72bd4dd06114c136ee6e04a1bdf5a19d0af58ed > > > Diff: https://reviews.apache.org/r/63316/diff/2/ > > > Testing > ------- > > `./gradlew test` > > > Thanks, > > Jordan Ly > >
