Re: Review Request 63339: Search entire job name for query string on JobList

[Aurora ReviewBot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63339/#review189348
-----------------------------------------------------------



Master (875a312) is red with this patch.
  ./build-support/jenkins/build.sh

                             # Create file stdout for capturing output. We 
can't use StringIO mock
                             # because TestProcess is running fork.
                             with open(os.path.join(td, 'sys_stdout'), 
'w+') as stdout:
                               with open(os.path.join(td, 'sys_stderr'), 
'w+') as stderr:
                                 with mutable_sys():
                                   sys.stdout, sys.stderr = stdout, 
stderr
                         
                                   p = TestProcess('process', 'echo hello 
world; echo >&2 hello stderr', 0,
                                                   taskpath, sandbox, 
logger_destination=LoggerDestination.BOTH)
                                   p.start()
                                   rc = 
wait_for_rc(taskpath.getpath('process_checkpoint'))
                         
                                   assert rc == 0
                                   # Check log files were created in std 
path with correct content
                     >             assert_log_content(taskpath, 'stdout', 
'hello world\n')
                     
                     src/test/python/apache/thermos/core/test_process.py:538: 
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     taskpath = <apache.thermos.common.path.TaskPath object at 
0x7f00c08fce90>
                     log_name = 'stdout'
                     expected_content = 'hello world\n'
                     
                         def assert_log_content(taskpath, log_name, 
expected_content):
                           log = 
taskpath.with_filename(log_name).getpath('process_logdir')
                           assert os.path.exists(log)
                           with open(log, 'r') as fp:
                     >       assert fp.read() == expected_content
                     E       assert '' == 'hello world\n'
                     E         + hello world
                     
                     src/test/python/apache/thermos/core/test_process.py:364: 
AssertionError
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/aaf4d108c31293299a0839bdc404a91802f80937.xml
 
                      1 failed, 794 passed, 6 skipped, 1 warnings in 
326.31 seconds 
                     
FAILURE


21:07:33 06:04   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 26, 2017, 1:53 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63339/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2017, 1:53 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Search entire job name for query string on JobList
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js 
> bb7f4885ae6a3452f953f69c7c89d87200539b00 
>   ui/src/main/js/components/__tests__/JobList-test.js 
> deda6fe8ba362c01ce5c9c9a2ab43e334043796d 
> 
> 
> Diff: https://reviews.apache.org/r/63339/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>