----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63337/#review189465 -----------------------------------------------------------
@ReviewBot retry - Reza Motamedi On Oct. 27, 2017, 5:01 p.m., Reza Motamedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63337/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2017, 5:01 p.m.) > > > Review request for Aurora and David McLaughlin. > > > Repository: aurora > > > Description > ------- > > # Polling updates page if in progress in UI > > This will update the job update page every 5 seconds if the update is in > progress. It was also stop refreshing the page if the update is not in > progress anymore. > > > Diffs > ----- > > ui/src/main/js/pages/Update.js c900269f0e47ccde616f021a7ecd51e13c57b734 > ui/src/main/js/pages/__tests__/Update-test.js > 570a999ccd60c646a1206941e968714e5457b1a4 > > > Diff: https://reviews.apache.org/r/63337/diff/3/ > > > Testing > ------- > > Checked in vagrant with a tunneled live scheduler and it works. Current tests > pass. > > > ``` > # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:ui-update-polling ? > [13:31:26] > ? ./gradlew ui:lint > > > Task :ui:lint > > > apache-aurora@1.0.0 lint /Users/rmotamedi/oss/aurora/ui > > eslint src/main/js plugin/ --ext .js > > > BUILD SUCCESSFUL in 15s > 4 actionable tasks: 1 executed, 3 up-to-date > > # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:ui-update-polling ? > [13:31:45] > ? ./gradlew ui:test > > > Task :ui:test > > > apache-aurora@1.0.0 test /Users/rmotamedi/oss/aurora/ui > > jest src/ plugin/ > > PASS src/main/js/pages/__tests__/Job-test.js > PASS src/main/js/components/__tests__/InstanceViz-test.js > PASS src/main/js/components/__tests__/ConfigDiff-test.js > PASS src/main/js/components/__tests__/Diff-test.js > PASS src/main/js/components/__tests__/InstanceHistoryItem-test.js > PASS src/main/js/utils/__tests__/Update-test.js > PASS src/main/js/components/__tests__/Pagination-test.js > PASS src/main/js/pages/__tests__/Update-test.js > PASS src/main/js/components/__tests__/UpdateList-test.js > PASS src/main/js/components/__tests__/UpdateInstanceEvents-test.js > PASS src/main/js/components/__tests__/JobStatus-test.js > PASS src/main/js/pages/__tests__/Instance-test.js > PASS src/main/js/components/__tests__/UpdateStatus-test.js > PASS src/main/js/components/__tests__/UpdateDiff-test.js > PASS src/main/js/components/__tests__/JobHistory-test.js > PASS src/main/js/components/__tests__/TaskNeighbors-test.js > PASS src/main/js/pages/__tests__/Updates-test.js > PASS src/main/js/pages/__tests__/Home-test.js > PASS src/main/js/components/__tests__/JobConfig-test.js > PASS src/main/js/test-utils/__tests__/Builder-test.js > PASS src/main/js/components/__tests__/JobList-test.js > PASS src/main/js/components/__tests__/Breadcrumb-test.js > PASS src/main/js/utils/__tests__/Task-test.js > PASS src/main/js/components/__tests__/Tabs-test.js > PASS src/main/js/components/__tests__/InstanceHistory-test.js > PASS src/main/js/components/__tests__/TaskList-test.js > PASS src/main/js/pages/__tests__/Jobs-test.js > PASS src/main/js/components/__tests__/RoleQuota-test.js > PASS src/main/js/utils/__tests__/Common-test.js > PASS src/main/js/components/__tests__/StateMachine-test.js > > Test Suites: 30 passed, 30 total > Tests: 134 passed, 134 total > Snapshots: 0 total > Time: 6.118s > Ran all test suites matching /src\/|plugin\//i. > > > BUILD SUCCESSFUL in 9s > 2 actionable tasks: 1 executed, 1 up-to-date > > ``` > > > Thanks, > > Reza Motamedi > >
