----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63435/#review189662 -----------------------------------------------------------
Ship it! LGTM since the current config lies, but added a wish list item. src/main/python/apache/aurora/executor/aurora_executor.py Line 98 (original), 98 (patched) <https://reviews.apache.org/r/63435/#comment266873> Bonus points for an `Awaiting task health checks` message when applicable. - Bill Farner On Oct. 30, 2017, 4:43 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63435/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2017, 4:43 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Repository: aurora > > > Description > ------- > > The message is no longer completely accurate, now that we remain in > `STARTING` until health checks have passed. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/aurora_executor.py > aeb3a4d4420c2a7a95ec9a866633bc0c0897ac56 > > > Diff: https://reviews.apache.org/r/63435/diff/1/ > > > Testing > ------- > > ./pants test.pytest src/test/python:: > > > File Attachments > ---------------- > > Screen Shot 2017-10-31 at 00.16.56.png > > https://reviews.apache.org/media/uploaded/files/2017/10/30/685d76fe-3db2-4761-80c1-f0af83642d0e__Screen_Shot_2017-10-31_at_00.16.56.png > > > Thanks, > > Stephan Erb > >
