-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63418/#review189675
-----------------------------------------------------------
Master (87eb891) is red with this patch.
./build-support/jenkins/build.sh
:distZip
:assemble
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processTestResources
:testClasses
:compileJmhJavaNote:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/discovery/ServiceInstance.java:29:
This final field could be made static
:pmdMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':pmdMain'.
> 1 PMD rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/pmd/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 4m 54s
40 actionable tasks: 31 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Oct. 30, 2017, 4:36 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63418/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 4:36 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This enables removal of some unnecessary complexity in the build (commons no
> longer needs thrift) and the unused Codec abstraction (we always encode in
> JSON).
>
>
> Diffs
> -----
>
> build.gradle 1c1d3811c861dc6ff16bbd9ce3daefb5833f52df
> commons/src/main/java/org/apache/aurora/common/io/Codec.java
> 94d1e3654767d8e5c0280595d0944c2fcb68ef90
> commons/src/main/java/org/apache/aurora/common/thrift/Util.java
> 4ef7f49b7953b56b592b2f8ac3e04df738615211
> commons/src/main/java/org/apache/aurora/common/zookeeper/Encoding.java
> 204f5c45b6810a82bdb74fb2d27fe2def6fd568a
> commons/src/main/java/org/apache/aurora/common/zookeeper/JsonCodec.java
> 9d316088ffd51b2dce816e6cc18d8e2a4a23cfd5
>
> commons/src/main/resources/org/apache/aurora/common/net/http/handlers/thrift.st
> 0586653e1b22a96b0ce71e2fc979d6d3a71d1677
> commons/src/main/thrift/org/apache/aurora/common/thrift/endpoint.thrift
> 87da2e13db900a4b06f50d89c9559ecfe202508e
> commons/src/test/java/org/apache/aurora/common/zookeeper/EncodingTest.java
> 16c017104c4696a985eefa23e1611300a7357259
> commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java
> 6cf335dd451ca05bb511d524ff5590b219505cae
> src/main/java/org/apache/aurora/scheduler/app/ServiceGroupMonitor.java
> a1329fd5010fadbf6bceeb2ae0476a6261830492
>
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
> 77f90eead2812e24d0d56e289bba7944075ee3bc
>
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
> eba56bea89961fd8e6507eaf4180f700e4b030c4
>
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
> 2847c41b15b64b6a91bae295a9e5a96680b0c816
> src/main/java/org/apache/aurora/scheduler/discovery/Encoding.java
> PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceInstance.java
> PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java
> bc0e2a86c0a8a354d95350a3d2f63514ee26da70
> src/main/java/org/apache/aurora/scheduler/http/StructDump.java
> 3ed256b30a0492d65560344c3fc038d8d93f2ec0
>
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java
> 02c81838c52245aad3c582e0dea62f4ca3693379
>
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java
> e6b57ee7d0af234a60794e10c63c2670f67e6ccd
>
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java
> 946a78e185962b1459ce0dc32c55a036d04a7e19
> src/test/java/org/apache/aurora/scheduler/discovery/EncodingTest.java
> PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java
> f3ae5a566b555b753230629897847c1bb5abc3b1
> src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java
> a7cc046d97d7b817a5496a6a7190142375b7a8a1
>
>
> Diff: https://reviews.apache.org/r/63418/diff/2/
>
>
> Testing
> -------
>
> e2e tests pass
>
>
> Thanks,
>
> Bill Farner
>
>
