----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63705/#review190629 -----------------------------------------------------------
Master (9b9b2ee) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 9, 2017, 1:42 p.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63705/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2017, 1:42 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Repository: aurora > > > Description > ------- > > David pointed out that this conditional in Webhooks was doing something that > a method already existed for. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java > 2af8118c85b1fa773968f51ab17dc9c2178fcff0 > > > Diff: https://reviews.apache.org/r/63705/diff/1/ > > > Testing > ------- > > Tests already exist for this conditional. > > `./gradlew test` > > > Thanks, > > Jordan Ly > >
