I ran `./build-support/jenkins/build.sh` and everything looked fine on my Mac. Can you tell me what the error message was?
Regards, ~RM On Tue, Nov 7, 2017 at 4:33 PM, David McLaughlin <da...@dmclaughlin.com> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63436/ > > On November 8th, 2017, 12:22 a.m. UTC, *Aurora ReviewBot* wrote: > > Master (ad86177) is green with this patch. > ./build-support/jenkins/build.sh > > I will refresh this build result if you post a review containing "@ReviewBot > retry" > > This fails for me consistently using: > > ./build-support/jenkins/build.sh > > Is anyone else able to reproduce my failure? > > > - David > > On October 31st, 2017, 8:15 p.m. UTC, Reza Motamedi wrote: > Review request for Aurora, David McLaughlin, Joshua Cohen, and Kai Huang. > By Reza Motamedi. > > *Updated Oct. 31, 2017, 8:15 p.m.* > *Repository: * aurora > Description > > Enabling ErrorBoundary in Scheduler UI > > React 16 introduces a new concept of an “error boundary” that allows us to > limit the impact of an error and not unmount the whole component tree. I am > open to keeping or removing the stack trace. > > from React docs: > > As of React 16, errors that were not caught by any error boundary will result > in unmounting of the whole React component tree. > > Testing > > > - Unit tests added. > > # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:error-boundry-test ? > [13:06:52] > ? ./gradlew ui:test > > BUILD SUCCESSFUL in 0s > 2 actionable tasks: 2 up-to-date > > # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:error-boundry-test ? > [13:07:46] > ? ./gradlew ui:lint > > BUILD SUCCESSFUL in 5s > 4 actionable tasks: 4 up-to-date > > > - For more testing, I added the following component (that raises an > error) and installed it under different components. I attached the > screen-shots of how this will render. Clicking the link initializes the > process of Jira ticket creation. > > ComponentWithError > > import React from 'react' > > export default class ComponentWithError extends React.Component { > render() { > throw new Error('Crashed!'); > return <div />; > } > } > > Diffs > > - ui/.eslintrc (5cdc4e67030a79c3f81c06f585cc9ff5ce959e52) > - ui/src/main/js/components/ErrorBoundary.js (PRE-CREATION) > - ui/src/main/js/components/__tests__/ErrorBoundary-test.js > (PRE-CREATION) > - ui/src/main/js/index.js (9f94d4bd6f649d74bdd9c3aa99783e01cae25d93) > > View Diff <https://reviews.apache.org/r/63436/diff/2/> > File Attachments > - Apache Jira ticket template filled with information on the bug > <https://reviews.apache.org/media/uploaded/files/2017/10/31/0b50175f-0dd5-44fe-8bc4-c69ca1723729__Screen_Shot_2017-10-31_at_11.55.39_AM.png> > - Catching exceptions on the router > <https://reviews.apache.org/media/uploaded/files/2017/10/31/915182ef-4229-4b22-b7c6-20a5f24f8e1a__Screen_Shot_2017-10-31_at_11.44.56_AM.png> >
