-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63743/#review190785
-----------------------------------------------------------



Should we remove `GatingDelayExecutor`/`GatedWorkQueue` as well? I believe they 
are only used in DB stores.

- Jordan Ly


On Nov. 11, 2017, 4:53 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63743/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2017, 4:53 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> :bugle playing taps:
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 1a3cbecfea01b4018dcbc99681508b9f3e58667d 
>   api/src/main/thrift/org/apache/aurora/gen/storage.thrift 
> ccb58258249978c6752ca6994fdaf01fa196134c 
>   build.gradle ddf153d7174dd0fb62f335fbc2bb2462263c553d 
>   src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java 
> 6f2f9f430d398c9326fa2beee35605be6468a149 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> ee10f476cd508ede05f93e68f143c8c440c81358 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  5229450cd21a6ada4e03d4841e17facfa4570235 
>   src/main/java/org/apache/aurora/scheduler/storage/db/AttributeMapper.java 
> a454887c27dfc80d753afb2b2c4b20fd330aea59 
>   src/main/java/org/apache/aurora/scheduler/storage/db/CronJobMapper.java 
> b07928d667f4b77330524f97178dec775ddb9a42 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 
> fee465bfda8f61e36f1162100d4467b721c13883 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java 
> e48a98223c0fd6d95ea8516d1a80ec4f068e988d 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 
> af854da1c6bf75c612c53a5d5c713a32f51cd420 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
> 9e28550c6e9e7e9cfdeb0bbfe3e4ba39f0148336 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 7bd37f7237dac56c92f9f267fae76d4d6e840df2 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbQuotaStore.java 
> 0ea21b566b15fd88ca3e1fb5ac8078fc325fc396 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStore.java 
> 026dfc977042fcba5c88ae56d94502cb362d1b54 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> aa7c03bce0238b76ae587373a972023f7aa56a8e 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 
> 573d76d5f8930bdd751fe204b046992f1b43e88b 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java 
> 443b473d1c6943c6c45007f5bc055189dcca0f43 
>   src/main/java/org/apache/aurora/scheduler/storage/db/EnumBackfill.java 
> b4731c9d9506a45c0b0099f064c9cb260333db75 
>   src/main/java/org/apache/aurora/scheduler/storage/db/EnumValueMapper.java 
> 33948a73a2c6050ac728bd66b0b5579accecd92e 
>   src/main/java/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.java 
> 240767c40e220e8cfa731d717679a19cd366dd3e 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/GarbageCollectedTableMapper.java
>  83e42a9701d25030ba28bb6218614d962392ca59 
>   src/main/java/org/apache/aurora/scheduler/storage/db/InsertResult.java 
> 8a81579dd1f37c4cb91008749ded0203520dba14 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java
>  caf1d64bf226b50cfa298dda00eab7efc90a908a 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobInstanceUpdateEventMapper.java
>  591b781239b0132c436fbc7eeb5e36b98e7640e9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/JobKeyMapper.java 
> ac0a998de560c0198b3206024285a2a6306b60bc 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
>  91053efe35de5234c6c320d410f15b45286bd86f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateEventMapper.java
>  d1a3c3f115e8dcb83e400a9a55c126c06a3cfaf7 
>   src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java 
> 9760674adab98d612a17420f91d5a644465f61f1 
>   src/main/java/org/apache/aurora/scheduler/storage/db/LockMapper.java 
> b9f338ce923405805ed083cba3fd8a75dbbdddce 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManager.java 
> fa986daa3dad54e53cd635b64493641d318c4a9a 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImpl.java
>  f9b8c427cd57176bc6228f9e95c02f7594f9bed2 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationMapper.java 
> 0c17aa7b03b0cc5000415469c49c77aafdcce479 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MyBatisCacheImpl.java 
> d9d406f8c22ed6393e5276a099020ff46bdcaa05 
>   src/main/java/org/apache/aurora/scheduler/storage/db/PruneVictim.java 
> 144f5a3cc6f1323d351f7c37685230bc824cbe39 
>   src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java 
> 7ebbb43ea5f60cb5483963dd278a812a0ca28b78 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java 
> d29bcf3d9980c885edf1841a010cfcf65ceb67a7 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> d2eb6aa6e4a155b2d28debab2ca10dfc76d57213 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> cda55c55680a19ed421299a8949299b21949787b 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskMapper.java 
> cbcef8476071ee1b55b8137548bb187b1f3f1cd7 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V001_CreateAppcImagesTable.java
>  073577202f79e8519abea756c5c04dc02244bc5f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V002_CreateDockerImagesTable.java
>  9a1ef28b2e5ecb43b3d22e750c9b6352de24641b 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V003_CreateResourceTypesTable.java
>  76c69164c70d526e7d4aa530e53531bf05f4b951 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V004_CreateTaskResourceTable.java
>  af106a8a9ee8c14122e98bcc0ec44b616f21d61f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V005_CreateQuotaResourceTable.java
>  cd06346199b04483c4a4aa0564cb3caa58dae0c8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V006_PopulateTierField.java
>  ac85b54218e1ebc73a78c76dc8dbefe8b8bb3456 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V007_CreateMesosFetcherURIsTable.java
>  d474e17c2c76dacfdaa948b16934b2b9374de98e 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V008_CreateUpdateMetadataTable.java
>  bc862714a4f7c6bfb92f76473a7a5932cb9ea1ac 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V009_CreateContainerVolumesTable.java
>  f6cd06abd017bd4f420b2417031d364f88d98244 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V010_RemoveUniqueConstraint.java
>  08c38f3163736c79904c088c9251032514aee8d1 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/AbstractTEnumTypeHandler.java
>  69f125b2564dd4839a0a876c0183e98fb4d0ddb9 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/CronCollisionPolicyTypeHandler.java
>  b87a29f8d105452b7f272b9bf841031da01d1410 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateActionTypeHandler.java
>  85ead7062c68d7cc8d797edf87bf6ed14de655ca 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateStatusTypeHandler.java
>  2848bf83052b1dc4bf709e13132b88d42c42d8c5 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/MaintenanceModeTypeHandler.java
>  8373ec78bbbf1abb0df6a096c4f59cac3749368f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/ResourceTypeHandler.java
>  e1bb7fd21700852808e24571cdcac04a2d2b186a 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/ScheduleStatusTypeHandler.java
>  b6b4f25dc9e3208d905d8acbad6b0758ffe5fcf3 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java
>  07e8c0b61763e9b585a1646741431a0bd3c57378 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler.java
>  97f65e444f0fdc8c58ef6787d049685368009d9f 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResource.java 
> 95a6de3b60d63abe503f5254ce0c7cc543e987d2 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResourceAggregate.java
>  461d5c2a2d4659c102cc49b2c7daabe0fd8f3c5b 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DBSaveQuota.java 
> 3d4859264ef789100f6c0197eab0bb0fd4cdc328 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssginedPort.java
>  fdfff774e13f3e5f5e2c08f4692bc61427f2cbaf 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java
>  cbc6a0c6085287f8065f182c24f79e47812af498 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbConstraint.java 
> 93667574ce97bd224b8de58d424efdbfb0114217 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java 
> 8d4d7eca3a17a3b96bbbdec9271503e7e71b3aff 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbImage.java 
> 5964a2a0b1f602eda0f8f2a8f31a2f15d93dcca7 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java
>  f3fd7a96326408a990ab5014b86336759902f462 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobConfiguration.java
>  40a5013b62d459d9c766c765f9e536f7042757e1 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java 
> 78703e92c932cd5e93ff0b70f2a0b6928f6b4003 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java
>  3a5272471e15177a35397acea920198499d16f0b 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java
>  d19aa859bcc5da2c9c7d4ebbb8db307a1ea2883e 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbScheduledTask.java
>  6260923b5aa67e45d9247b1f1a77f114cb3fcb0a 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java
>  8ec6d4710964fd64d24774a719baffa27502c607 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
> 138cd5316adc73eed24fc7accc53885dd5d5bee5 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConstraint.java
>  e3e1b7ae25a63e13e2dc288d29c4cd3ea416915f 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/LockRow.java 
> aaa0a68ae936e3ba095de940aad7184a1de50a31 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/MigrationChangelogEntry.java
>  6159af612381c86e7a8e6f53fe505199a9a39033 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java 
> 106b7affbde8ced27722ca6dbec95580710d647f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 32588794bd2c62f3e1eeee38113053e698e281de 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml 
> d49c90bde1714805560a01af393b41137432aeca 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml 
> 1434f45ca0bc188bfb0f2ef3c25fbcd102a3ccb1 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/EnumValueMapper.xml 
> b1f9672147dae3a516f83778a39f3a733b26eb2e 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.xml
>  74568ab690bc12a749b22f34f3e265eebf9f949f 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobInstanceUpdateEventMapper.xml
>  1b58406beb503b98844ee0dad81bde17827fd898 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml 
> 3b5a7c9f37e4e947c11735972024920b94f61a99 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  aded483cef34940be29449694fa5eeaff85a7fbd 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateEventMapper.xml
>  910d8300784d4588e55e051123a521679362c6a4 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml 
> ce8ed3a5938a4a16c300fd09e22469347c210284 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/MigrationMapper.xml 
> f6881ac68c51b024277aa1849c3b8144d3237497 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/QuotaMapper.xml 
> 0f469687dfc7c3d77f00b69b7d83a3043810417a 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  5422183e4a1fe122fc0e1aa871aa75ae102e322d 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 
> 0ecffab8757701d58a33d0fb0ec4357c93c7a337 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 7a86f47af67adb3e488381d30ddf424549deefbc 
>   src/test/java/org/apache/aurora/scheduler/http/H2ConsoleModuleIT.java 
> b8a419ce01a9d5afcc63b0b65f2296ef34b1bec9 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java
>  be9194069e40b7cb512e6e8a51f7b777cfacb3e5 
>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 
> 08579744b36b0aa08a87cd9fc532b8b40c439a36 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/AttributeStoreTest.java 
> 46dc7f523d0b1d1fc3ea2991d415ff5e2d3831fc 
>   src/test/java/org/apache/aurora/scheduler/storage/db/CronJobStoreTest.java 
> dd9da196bf73fffa46a2823769e8e204b9b46c65 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 
> 2229e4e7e276a39580d9f3744e716c7e65313b6b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptorTest.java
>  c7d437f2dd1de5fe7b9613a94c6f3bb35360f4f6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/JobUpdateStoreTest.java 
> f7e355b0350c8ee800575cf41682093d9f14b815 
>   src/test/java/org/apache/aurora/scheduler/storage/db/LockStoreTest.java 
> e2965b2766f6f8dd84a168139de23c1e5641045d 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImplIT.java
>  d594bced6c4db1b8db9a31c13512160512b77b36 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/MyBatisCacheImplTest.java
>  1ed1a12dbd3de727980a2ef398e17a5427037eaa 
>   src/test/java/org/apache/aurora/scheduler/storage/db/QuotaStoreTest.java 
> 048db069143b299c8e1f9030da120849f4957c44 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollectorTest.java
>  74c9d1d2fba94971106c148ac76d5a76dab6a7b4 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/SchedulerStoreTest.java 
> 55c4576d551cd83b6527c9a87206a0d614ad3dac 
>   src/test/java/org/apache/aurora/scheduler/storage/db/TaskStoreTest.java 
> 45a2f1191785f11112b3f1859be06da083bc7418 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V001_TestMigration.java
>  45a5b5ef0275286c1d6619486e7b691afe73020f 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V002_TestMigration2.java
>  621ca4c10cc1c0a420aaa84e108b43e24b55c09c 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java
>  5a28f0ba9325624d8a139f1ce844d6a00082d59b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStoreTest.java
>  66b415cc395d09b15b977d0c54be94dd907a8485 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 
> 9e75c98dfd5fcb949cd8a3ff2030892ac3b17180 
> 
> 
> Diff: https://reviews.apache.org/r/63743/diff/2/
> 
> 
> Testing
> -------
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to