> On Sept. 27, 2017, 1:53 a.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years old. I assumed they have a good reason for it > and considered an added dependency a less risky endeavor. (Or is it just > negligence?) > > Bill Farner wrote: > What i meant to say - currently, i can build aurora on a stock macOS > machine with only a modern JDK and xcode command line utilities. Thrift > 0.10.0 seems to put us in the position of choosing between: > > a.) adding another step to our bootstrap routine to pre-build bison > b.) adding bison as a build-time dependency > c.) adding cmake as a build-time dependency > d.) other options? (i'd like to float the idea of hosting thrift binaries > like how pants does) > > Stephan Erb wrote: > Giving it some thought, you are right that just requring cmake does not > improve the situation in any way. > > I also like that we can build Aurora on a stock MacOS without much hassle > (or administrator rights). I think we should retain this property. This would > restrict us to options a) and d). > > Bill Farner wrote: > I would support (d). We can place unofficial binaries in svn for dev > platforms as needed, and could support using thrift from the `PATH` as a > fallback. This has the bonus of making from-scratch builds much faster. > > Stephan Erb wrote: > I saw your patch to https://github.com/morimekta/providence. Did you > manage to get something working with it? > > Bill Farner wrote: > I'm about 20% along. A very large mechanical patch is needed for Aurora. > The only untested piece is binary format compatibility (which providence > aims to achieve). There is some incompatibility i need to investigate > further (trivial details like a round-tripped `null` collection turning into > an empty collection), but so far it looks good! I'm proceeding with high > confidence, as there is also the future promise of a more approachable > HTTP/JSON interface via thrift IDL when using providence. > > Bill Farner wrote: > I should have clarified - i don't think we should hold back on upgrading > thrift. It's not yet guaranteed that the migration to providence will be > successful or timely. > > As for my proposed (d) above, we could store prebuilt binaries similarly > to how we store mesos eggs: https://svn.apache.org/repos/asf/aurora/3rdparty/
I have just pushed another patch that I have been sitting one for a few days. It suffers from the same pants issues as https://reviews.apache.org/r/63750/ - Stephan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/#review186342 ----------------------------------------------------------- On Dec. 3, 2017, 9:09 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62590/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2017, 9:09 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to make `./pants gen` > working. Unfortunately this breaks a few things. For details see > https://reviews.apache.org/r/63750/ > * The Java `hashcode` option has been removed as it is now the default. > > > Diffs > ----- > > 3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388ee04b5a > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle af119910e84c48f75f2573ababcfa287c3b986fc > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/executor/BUILD > 486230db34a22ea5dd0f68da911c0afb1afbcac0 > > > Diff: https://reviews.apache.org/r/62590/diff/2/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Stephan Erb > >
