----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64359/#review192965 -----------------------------------------------------------
Ship it! One small question but LGTM. build.gradle Lines 120 (patched) <https://reviews.apache.org/r/64359/#comment271395> is this used? - Jordan Ly On Dec. 6, 2017, 3:55 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64359/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2017, 3:55 a.m.) > > > Review request for Aurora and Jordan Ly. > > > Repository: aurora > > > Description > ------- > > I finally decided to dig into the cause of multiple slf4j jars causing > trouble running tests in intellij. Turns out that while we are strict about > dependency versions for the `compile` configuration, the build allowed > version conflicts in the `test` configuration. This led to multiple slf4j > versions. > > > Diffs > ----- > > build.gradle af119910e84c48f75f2573ababcfa287c3b986fc > > > Diff: https://reviews.apache.org/r/64359/diff/1/ > > > Testing > ------- > > `./gradlew idea`, 'External Libraries' no longer has rogue slf4j jars, and > tests don't fail as a result. > > > Thanks, > > Bill Farner > >
